Skip to content

187 support flow types #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Feb 22, 2018
Merged

187 support flow types #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
d1da812
Start support for Flow typing in base_component create_docstring
mjclawar Jan 29, 2018
312745e
Fix `Array` Flow type
coralvanda Jan 29, 2018
d7c78c5
Fix `union` Flow type
coralvanda Jan 29, 2018
383d38b
Fix `signature` Flow type
coralvanda Jan 29, 2018
f6f3838
Work on indenting nested props
coralvanda Jan 29, 2018
5b34378
Update docstrings for indentations
mjclawar Jan 30, 2018
60ec7e3
Add `indent_num` to func and call
coralvanda Jan 30, 2018
0adeeac
Add `indent_num` to func and call
coralvanda Jan 30, 2018
ccca6c2
Remove unnecessary string formatting, correct names of `boolean` and …
coralvanda Jan 30, 2018
a648cef
Remove TODO
coralvanda Jan 30, 2018
d7168b5
Reformat string
coralvanda Jan 30, 2018
92ccca6
Rename test component
coralvanda Jan 30, 2018
215078b
Add func to test flow docstring
coralvanda Jan 30, 2018
47975d1
Add additional metadata to test in `base_component`
coralvanda Jan 30, 2018
ae3eaa0
Remove unintentionally committed file
coralvanda Jan 30, 2018
60299b1
Add test file for flow metadata
coralvanda Jan 30, 2018
45a838b
Add test for flow metadata to docstring
coralvanda Jan 30, 2018
c39230a
Reword descriptions of props for testing
coralvanda Jan 30, 2018
a7db004
Rename prop names for testing consistency
coralvanda Jan 30, 2018
923576e
Correct format in expected value for test
coralvanda Jan 30, 2018
5d9ad5f
Remove `__main__` section (no longer needed)
coralvanda Jan 30, 2018
d669af3
Start support for Flow typing in base_component create_docstring
mjclawar Jan 29, 2018
828203f
Fix `Array` Flow type
coralvanda Jan 29, 2018
8412160
Fix `union` Flow type
coralvanda Jan 29, 2018
2bd816e
Fix `signature` Flow type
coralvanda Jan 29, 2018
af1b55b
Work on indenting nested props
coralvanda Jan 29, 2018
b602786
Update docstrings for indentations
mjclawar Jan 30, 2018
051d3ee
Add `indent_num` to func and call
coralvanda Jan 30, 2018
b674fe1
Add `indent_num` to func and call
coralvanda Jan 30, 2018
df48bc6
Remove unnecessary string formatting, correct names of `boolean` and …
coralvanda Jan 30, 2018
8e62673
Remove TODO
coralvanda Jan 30, 2018
eb39c67
Reformat string
coralvanda Jan 30, 2018
8e2d3da
Rename test component
coralvanda Jan 30, 2018
6d8d969
Add func to test flow docstring
coralvanda Jan 30, 2018
d321294
Add additional metadata to test in `base_component`
coralvanda Jan 30, 2018
e75667a
Remove unintentionally committed file
coralvanda Jan 30, 2018
bdec9ef
Add test file for flow metadata
coralvanda Jan 30, 2018
a567884
Add test for flow metadata to docstring
coralvanda Jan 30, 2018
21ad258
Reword descriptions of props for testing
coralvanda Jan 30, 2018
948c14c
Rename prop names for testing consistency
coralvanda Jan 30, 2018
20f4b04
Correct format in expected value for test
coralvanda Jan 30, 2018
3524427
Remove `__main__` section (no longer needed)
coralvanda Jan 30, 2018
990ffe2
Merge remote-tracking branch 'origin/187-support-flow-types' into 187…
mjclawar Jan 30, 2018
7bb01f8
Update version to 0.20.1
mjclawar Jan 30, 2018
09143c1
Update CHANGELOG and remove old base component backup code
mjclawar Jan 30, 2018
09b3017
Fix line length errors in tests
mjclawar Jan 30, 2018
821c793
Fix PEP8 issue with indentation
mjclawar Jan 30, 2018
995ca98
Appease the pylint demon.
mjclawar Jan 30, 2018
86dc4d2
pylint in Component docstring formatting
mjclawar Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 0.20.1 - 2018-01-30
## Added
- `component_loader` now has the following behavior to create docstrings
as determined in discussion in [#187](https://github.com/plotly/dash/issues/187):
1. If a Dash component has `PropTypes`-generated typing, the docstring uses the `PropTypes`, _regardless of whether the component also has Flow types (current behavior)._
2. Otherwise if a Dash component has Flow types but _not `PropTypes`_, the docstring now uses the objects generated by `react-docgen` from the Flow types.

## 0.20.0 - 2018-01-19
## Added
- `exceptions.PreventUpdate` can be raised inside a callback to elegantly prevent
Expand Down
Loading