-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fixed viewport meta-tags #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixed viewport meta-tags #2084
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,6 +133,29 @@ def test_inin007_meta_tags(dash_duo): | |
assert meta_tag.get_attribute("content") == meta_info["content"] | ||
|
||
|
||
def test_inin007b_change_viewport_meta_tag(dash_duo): | ||
""" | ||
As of dash 2.5 the default viewport meta tag is: | ||
[{"name": "viewport", "content": "width=device-width, initial-scale=1"}] | ||
Test verifies that this feature can be disabled by using an empty viewport tag. | ||
""" | ||
|
||
app = Dash(meta_tags=[{"name": "viewport"}]) | ||
|
||
app.layout = html.Div(id="content") | ||
|
||
dash_duo.start_server(app) | ||
|
||
meta = dash_duo.find_elements("meta") | ||
|
||
# -3 for the meta charset, http-equiv and viewport. | ||
assert len(meta) == 3, "Should have 3 meta tags" | ||
|
||
viewport_meta = meta[2] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better not to depend on the order of the returned meta elements. Also if we add more default meta tags in the future this test would need to change. Instead, find just the viewport tags and ensure there's exactly one:
|
||
assert viewport_meta.get_attribute("name") == "viewport" | ||
assert viewport_meta.get_attribute("content") == "" | ||
|
||
|
||
def test_inin008_index_customization(dash_duo): | ||
app = Dash() | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather we not squeeze test numbers in between with
b
or such - makes it harder to run just one test with egpytest -k inin007
. Just shift some of the other test numbers so this one can have its own. Maybe the ones up front since this file starts atinin004
?