Skip to content

No console log #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## [UNRELEASED]

- [#2146](https://github.com/plotly/dash/pull/2146) Remove leftover debug console.log statement.

## [2.6.0] - 2022-07-14

### Added
Expand Down
1 change: 1 addition & 0 deletions dash/dash-renderer/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ module.exports = {
'prefer-arrow-callback': 2,
'quote-props': [2, 'as-needed'],
'quotes': [2, 'single', { 'avoidEscape': true }],
'no-console': 2,
'@typescript-eslint/ban-types': 0,
'@typescript-eslint/explicit-module-boundary-types': 0,
'@typescript-eslint/array-type': 0,
Expand Down
1 change: 1 addition & 0 deletions dash/dash-renderer/src/actions/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export default function apiThunk(endpoint, method, store, id, body) {
// fetch rejection - this means the request didn't return,
// we don't get here from 400/500 errors, only network
// errors or unresponsive servers.
// eslint-disable-next-line no-console
console.log('fetch error', res);
setConnectionStatus(false);
return;
Expand Down
1 change: 0 additions & 1 deletion dash/dash-renderer/src/actions/callbacks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,6 @@ export function executeCallback(
let lastError: any;

const additionalArgs: [string, string, boolean?][] = [];
console.log(cb.callback.output, getState().callbackJobs);
values(getState().callbackJobs).forEach(
(job: CallbackJobPayload) => {
if (cb.callback.output === job.output) {
Expand Down