-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to hashing compatability issues [2697] with some environments (FIPS) #2817
Conversation
All looks good to me. Thanks for your work on this, @caplinje-NOAA . The failing test you mentioned is working in the CI, and also on my local machine, so I don't see an issue there. |
Co-authored-by: Philippe Duval <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR resolves 2697, and is mostly a find and replace of hashlib.md5 and hashlib.sha1 with hashlib.sha256. I did not replace one instance of sha1 in testing. sha256 is slightly slower than md5, but testing did not show a measurable change in performance for creating callback ids. Further, though they are generally extremely unlikely, sha256 has a reduced risk of collisions.
Contributor Checklist
optionals
CHANGELOG.md