Skip to content

Fixes 'AttributeError' when layout is a function that returns a list of components in dash layout setter #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Fixes 'AttributeError' when layout is a function that returns a list of components in dash layout setter #2915

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
103412d
fix: AttributeError when layout is a function in dash layout setter
martian0x80 Jul 6, 2024
3daf38e
chore: Add CHANGELOG entry
martian0x80 Jul 7, 2024
f26d8bf
chore: Refactor Dash validation layout logic
martian0x80 Jul 26, 2024
90c9c5b
Merge branch 'dev' into layout-function-patch
martian0x80 Jul 26, 2024
ab2a02e
chore: format
martian0x80 Aug 10, 2024
e0e9a6a
Merge branch 'dev' into layout-function-patch
T4rk1n Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- [#2896](https://github.com/plotly/dash/pull/2896) The tabIndex parameter of Div can accept number or string type. Fixes [#2891](https://github.com/plotly/dash/issues/2891)
- [#2900](https://github.com/plotly/dash/pull/2900) Allow strings in layout list. Fixes [#2890](https://github.com/plotly/dash/issues/2890)
- [#2908](https://github.com/plotly/dash/pull/2908) Fix when environment variables are ignored by Dash.run() at runtime. Fixes [#2902](https://github.com/plotly/dash/issues/2902)
- [#2915](https://github.com/plotly/dash/pull/2915) Fix 'AttributeError' when layout is a function that returns a list of components. Fixes [#2905](https://github.com/plotly/dash/issues/2905)

## [2.17.1] - 2024-06-12

Expand Down
4 changes: 4 additions & 0 deletions dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,10 @@ def simple_clone(c, children=None):
return cls(**props)

layout_value = self._layout_value()

if isinstance(layout_value, (list, tuple)):
layout_value = html.Div(children=layout_value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the function simple_clone and assign the self.validation_layout = layout_value instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will make requested changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


_validate.validate_layout(value, layout_value)
self.validation_layout = simple_clone(
# pylint: disable=protected-access
Expand Down