Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets_ignore init keyword, regex filter for the assets files. #318

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Aug 2, 2018

Resolves #306, add a regex ignore filter to the assets auto include on the index.

import dash

app = dash.Dash(assets_ignore='.*ignored.*')

The ignored assets are still available from a request context (a callback):

flask.url_for('assets', filename='ignored.css')

They won't work with #309 .

@chriddyp
Copy link
Member

They won't work with #309 .

Let's get #309 first, then revisit this one

@radekwlsk
Copy link

@chriddyp @T4rk1n As #309 is released in 0.24.0 as I believe, I assume this one is no longer ready for release and has to be updated?

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Aug 13, 2018

They won't work with #309 .

I meant that they won't have the query string with the modified time when you get them from somewhere else than the assets includes.

@chriddyp
Copy link
Member

💃

@T4rk1n T4rk1n merged commit e5f7d20 into master Aug 20, 2018
@T4rk1n T4rk1n deleted the assets-ignore branch September 7, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants