Remove stringcase #3239
Merged
Remove stringcase #3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heng-m-xr
approved these changes
Mar 24, 2025
gvwilson
approved these changes
Mar 24, 2025
ndrezn
approved these changes
Mar 24, 2025
emilykl
reviewed
Mar 24, 2025
| r"[\-_\.\s]([a-z])", lambda match: match.group(1).upper(), name[1:] | ||
| ) | ||
|
|
||
|
|
||
| def generate_shape(type_info, component_name: str, prop_name: str): |
There was a problem hiding this comment.
@T4rk1n Is this function covered by tests? Will anything break in a very deep way if this function returns a slightly different output following this change? (The regex looks solid but just in case)
There was a problem hiding this comment.
It would just be the name of the generated type, I don't think it would break. It's also almost the same as what stringcase was doing.
There was a problem hiding this comment.
@emilykl I added a unit test for the pascal_case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3238