-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collapse button to devtools #3241
Conversation
What happens if there are errors when it is collapsed? |
@BSd3v Good question! Currently what happens is the list of errors pop up either way, and it doesn't affect the collapse state of the devtools menu. So if it's collapsed and there's an error, you see this at the bottom right: This did actually help me catch an edge case though where if you dismiss the error dialog and the devtools are collapsed, nothing happens when you get an error. |
This is where this would be handy. 😉 |
While at it, could you also make it so we can download the errors. XD |
Good ideas, but let's not let scope creep here! We came up with plenty of others during the devtools redesign 😉 When there is an error/version update but the devtools are minimized it will show a red notification dot with no number. @jeromevaldez is on design for that. |
max-width: 50px; | ||
} | ||
.dash-debug-menu__outer.dash-debug-menu__outer--expanded { | ||
width: 682px; | ||
max-width: 682px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try fit-content
? It might work as long as the internal components use a width pre-defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried that and it didn't work. It's tricky to add the sliding behavior! Looks like there's this experimental css feature that could be good once it has higher adoption, but from what I've seen there aren't amazing options other than the max-width hard-coding for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice refactor to a functional component 💃
User facing changes
Code changes
DebugMenu
from a class component to functional component (it made using state easier and we're trying to move components to that anyway).