Move the dash.layout.setter so that type checkers can find it easier #3249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rearranges two methods of the Dash class.
Specifically you now have
@property def layout // @layout.setter def layout // def _layout_value
instead of@property def layout // def _layout_value // @layout.setter def layout
.The point is to make it easier for type checkers (such as mypy) to connect the
@property layout
with thelayout.setter
, so that people who use this library with a type checker need fewer#type: ignore
statements.This is a very minimal change, and I don't see how it could break anything, or make anything worse. I don't think a note in the changelog is necessary.
Contributor Checklist
optionals
CHANGELOG.md