-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Pick up app name from server instance (#771) #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great, thanks! Would you mind adding a test, perhaps in https://github.com/plotly/dash/blob/master/tests/unit/test_configs.py, that just instantiates an |
💯 I don't know why a user would do this, but it should definitely behave the way you've done it! |
@alexcjohnson I see that https://github.com/plotly/dash/blob/master/tests/unit/test_configs.py still use unitest, am I free to import pytest? |
Yes, you are more than welcome to use |
f4daea3
to
f2ef207
Compare
It should be good now. To keep a narrow scope for this PR I added the bare minimum for the test but I would be glad to continue this work in a new PR with a full convertion to pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful test, thanks! 💃
And yes, you're right that it's best not to mix in other topics like converting more tests to pytest
into this PR. But if you're interested in helping that process in another PR we would love to have your contribution! If you haven't seen it, https://github.com/plotly/dash-docs/pull/520 describes the new pytest
fixtures we (@byronz) made, which are in master here but have not yet been released.
* Added conditionally set props * Updated changelog. * Added integration test to check callbacks
* Added conditionally set props * Updated changelog. * Added integration test to check callbacks
Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!
Contributor Checklist
optionals
CHANGELOG.md
Details
I changed the default name arg value from
__main__
toNone
in order to distinguish "not passing a name" from "setting explicitly the name to__main__
". I figured it would be the best course of action to avoid unwanted renaming cases.