-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Generalized persistence #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8,309
−7,677
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7a21285
persistence initial commit
alexcjohnson b737a3f
flip the loop in recordUiEdit
alexcjohnson 6509121
clarify persistence getProps usage
alexcjohnson 42428a6
update persistence comment for nested prop IDs
alexcjohnson 78df979
allow multiple pieces of persistence for one prop
alexcjohnson 83b8cd3
fallback if web store isn't available, or is full from the start
alexcjohnson cb179c9
fix missed props propagation
alexcjohnson b4ebb51
clean up package.json and upgrade to babel 7
alexcjohnson 3b56686
remove obsolete dash-renderer package test script
alexcjohnson 5ff00cf
unit test (and fix bugs) storage & fallbacks
alexcjohnson 690b0a3
Merge branch 'dev' into persistence
alexcjohnson 3669df6
cleaner error when storage fills up
alexcjohnson 15ca0e5
get rid of no-undefined eslint rule
alexcjohnson c9230f5
renderer persistence changelog
alexcjohnson abde83f
integration tests - and a fix - for persistence
alexcjohnson 4b11f07
prevent ambiguous double-installation of the rest of core on CI
alexcjohnson 0626ea9
linux flavor of sed?
alexcjohnson ba8d5ba
update build to corejs@3
alexcjohnson 09b9393
store different persisted values for each persistence id
alexcjohnson 5fa4d55
more "random" new column name
alexcjohnson 53ab7c5
lint test_persistence
alexcjohnson 118547f
fix unit tests and error handler for multi-ID persistence
alexcjohnson 130a857
Merge branch 'dev' into persistence
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,6 @@ | ||
{ | ||
"presets": ["es2015", "react", "stage-2"], | ||
"env": { | ||
"development": { | ||
"presets": ["es2015", "react", "stage-2"], | ||
"plugins": [ | ||
["transform-es2015-modules-commonjs-simple", { | ||
"noMangle": true | ||
}] | ||
] | ||
} | ||
} | ||
"presets": [["@babel/preset-env", { | ||
"useBuiltIns": "usage", | ||
"corejs": 3 | ||
}], "@babel/preset-react"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,181 @@ | ||
// For a detailed explanation regarding each configuration property, visit: | ||
// https://jestjs.io/docs/en/configuration.html | ||
|
||
module.exports = { | ||
// All imported modules in your tests should be mocked automatically | ||
// automock: false, | ||
|
||
// Stop running tests after the first failure | ||
// bail: false, | ||
|
||
// Respect "browser" field in package.json when resolving modules | ||
// browser: false, | ||
|
||
// The directory where Jest should store its cached dependency information | ||
// cacheDirectory: "/var/folders/8m/wrr89jfx5kg5xhp7q2127bcc0000gn/T/jest_dx", | ||
|
||
// Automatically clear mock calls and instances between every test | ||
clearMocks: true, | ||
|
||
// Indicates whether the coverage information should be collected while executing the test | ||
// collectCoverage: false, | ||
|
||
// An array of glob patterns indicating a set of files for which coverage information should be collected | ||
// collectCoverageFrom: null, | ||
|
||
// The directory where Jest should output its coverage files | ||
coverageDirectory: "coverage", | ||
|
||
// An array of regexp pattern strings used to skip coverage collection | ||
// coveragePathIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// A list of reporter names that Jest uses when writing coverage reports | ||
// coverageReporters: [ | ||
// "json", | ||
// "text", | ||
// "lcov", | ||
// "clover" | ||
// ], | ||
|
||
// An object that configures minimum threshold enforcement for coverage results | ||
// coverageThreshold: null, | ||
|
||
// Make calling deprecated APIs throw helpful error messages | ||
// errorOnDeprecated: false, | ||
|
||
// Force coverage collection from ignored files usin a array of glob patterns | ||
// forceCoverageMatch: [], | ||
|
||
// A path to a module which exports an async function that is triggered once before all test suites | ||
// globalSetup: null, | ||
|
||
// A path to a module which exports an async function that is triggered once after all test suites | ||
// globalTeardown: null, | ||
|
||
// A set of global variables that need to be available in all test environments | ||
// globals: {}, | ||
|
||
// An array of directory names to be searched recursively up from the requiring module's location | ||
// moduleDirectories: [ | ||
// "node_modules" | ||
// ], | ||
|
||
// An array of file extensions your modules use | ||
// moduleFileExtensions: [ | ||
// "js", | ||
// "json", | ||
// "jsx", | ||
// "node" | ||
// ], | ||
|
||
// A map from regular expressions to module names that allow to stub out resources with a single module | ||
moduleNameMapper: { | ||
"\\.(css|less)$": "identity-obj-proxy" | ||
}, | ||
|
||
// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader | ||
// modulePathIgnorePatterns: [], | ||
|
||
// Activates notifications for test results | ||
// notify: false, | ||
|
||
// An enum that specifies notification mode. Requires { notify: true } | ||
// notifyMode: "always", | ||
|
||
// A preset that is used as a base for Jest's configuration | ||
// preset: null, | ||
|
||
// Run tests from one or more projects | ||
// projects: null, | ||
|
||
// Use this configuration option to add custom reporters to Jest | ||
// reporters: undefined, | ||
|
||
// Automatically reset mock state between every test | ||
// resetMocks: false, | ||
|
||
// Reset the module registry before running each individual test | ||
// resetModules: false, | ||
|
||
// A path to a custom resolver | ||
// resolver: null, | ||
|
||
// Automatically restore mock state between every test | ||
// restoreMocks: false, | ||
|
||
// The root directory that Jest should scan for tests and modules within | ||
// rootDir: null, | ||
|
||
// A list of paths to directories that Jest should use to search for files in | ||
roots: [ | ||
"<rootDir>/tests" | ||
], | ||
|
||
// Allows you to use a custom runner instead of Jest's default test runner | ||
// runner: "jest-runner", | ||
|
||
// The paths to modules that run some code to configure or set up the testing environment before each test | ||
// setupFiles: ['<rootDir>/tests/setupTests.js'], | ||
|
||
// The path to a module that runs some code to configure or set up the testing framework before each test | ||
// setupTestFrameworkScriptFile: null, | ||
|
||
// A list of paths to snapshot serializer modules Jest should use for snapshot testing | ||
// snapshotSerializers: [], | ||
|
||
// The test environment that will be used for testing | ||
testEnvironment: "jsdom", | ||
|
||
// Options that will be passed to the testEnvironment | ||
// testEnvironmentOptions: {}, | ||
|
||
// Adds a location field to test results | ||
// testLocationInResults: false, | ||
|
||
// The glob patterns Jest uses to detect test files | ||
testMatch: [ | ||
"**/?(*.)+(spec|test).js?(x)" | ||
], | ||
|
||
// An array of regexp pattern strings that are matched against all test paths, matched tests are skipped | ||
// testPathIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// The regexp pattern Jest uses to detect test files | ||
// testRegex: "", | ||
|
||
// This option allows the use of a custom results processor | ||
// testResultsProcessor: null, | ||
|
||
// This option allows use of a custom test runner | ||
// testRunner: "jasmine2", | ||
|
||
// This option sets the URL for the jsdom environment. It is reflected in properties such as location.href | ||
// testURL: "http://localhost", | ||
|
||
// Setting this value to "fake" allows the use of fake timers for functions such as "setTimeout" | ||
// timers: "real", | ||
|
||
// A map from regular expressions to paths to transformers | ||
// transform: null, | ||
|
||
// An array of regexp pattern strings that are matched against all source file paths, matched files will skip transformation | ||
// transformIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// An array of regexp pattern strings that are matched against all modules before the module loader will automatically return a mock for them | ||
// unmockedModulePathPatterns: undefined, | ||
|
||
// Indicates whether each individual test should be reported during the run | ||
// verbose: null, | ||
|
||
// An array of regexp patterns that are matched against all source file paths before re-running tests in watch mode | ||
// watchPathIgnorePatterns: [], | ||
|
||
// Whether to use watchman for file crawling | ||
// watchman: true, | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byronz there seems to be something funny about how these built packages get picked up by the next step. The first time I ran these tests it looked like they got the old
dash-table
, but then running them again everything worked.Perhaps something funny about having the two steps
build-misc
andbuild-core
both writing to the same directorypackages
? Maybe they should each write to a separate dir, and we have thetest
job either recombine them into one before installing them, or just install from the two separate dirs?