Skip to content

Improve resource caching #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 28, 2019
Merged

Improve resource caching #973

Changes from 3 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3ba3822
add use of etag / if-none-match
Oct 22, 2019
608c0d7
black
Oct 22, 2019
d76804d
handling tuples
Oct 23, 2019
be23600
etag or fingerprint
Oct 23, 2019
9c3f2fe
lint
Oct 23, 2019
daf8d63
update resource tests
Oct 23, 2019
aa5e8f7
py2.7
Oct 23, 2019
61fe077
lint
Oct 23, 2019
8e6e2f2
clean up
Oct 23, 2019
5e61384
clean up
Oct 23, 2019
1933046
changelog
Oct 23, 2019
c16d069
- improve fingerprinting
Oct 24, 2019
47d3eb4
update handling of `@` in fingerprinting and test (for [email protected]…
Oct 24, 2019
6aa42aa
add tests for version and hash
Oct 24, 2019
e0847f5
clean up
Oct 24, 2019
d180533
hash
Oct 24, 2019
c71955e
fix error adding fingerprint to url
Oct 24, 2019
0e091f1
Update dash/dash.py
Marc-Andre-Rivet Oct 28, 2019
58afb82
Merge branch 'dev' into early-renderer
Marc-Andre-Rivet Oct 28, 2019
f156ede
plugin - distinguish local from remote script resources
Oct 28, 2019
199c8da
Merge branch 'early-renderer' of github.com:plotly/dash into early-re…
Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,10 +711,19 @@ def serve_component_suites(self, package_name, path_in_package_dist):
package.__path__,
)

return flask.Response(
response = flask.Response(
pkgutil.get_data(package_name, path_in_package_dist),
mimetype=mimetype,
)
response.add_etag()
(tag,) = response.get_etag()[:1]

request_etag = flask.request.headers.get('If-None-Match')

if '"{}"'.format(tag) == request_etag:
response = flask.Response(None, status=304)

return response

def index(self, *args, **kwargs): # pylint: disable=unused-argument
scripts = self._generate_scripts_html()
Expand Down