Skip to content

Fix display of stack traces within RStudio's viewer pane #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2019
Merged

Fix display of stack traces within RStudio's viewer pane #996

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
55435ce
:hammer: fix rendering of stack trace in R
Nov 4, 2019
e5d5921
:necktie: use prettier
Nov 4, 2019
89033ec
:necktie: use prettier
Nov 4, 2019
dfc1b3a
Update dash-renderer/src/components/error/FrontEnd/FrontEndError.reac…
rpkyle Nov 5, 2019
bf08944
:hocho: unnecessary :art:
Dec 4, 2019
c8e596e
Merge branch 'dev' into 994-fix-viewer
rpkyle Dec 4, 2019
c87bcdf
:necktie: run prettier
Dec 4, 2019
7c18dbf
Merge branch '994-fix-viewer' of github.com:plotly/dash into 994-fix-…
Dec 4, 2019
e7a1fce
Merge branch 'dev' into 994-fix-viewer
rpkyle Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dash-renderer/src/components/error/FrontEnd/FrontEndError.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,12 @@
overflow: hidden;
display: inline-block;
}

.dash-be-error__str {
background-color: #fdf3f4;
min-width: 386px;
max-width: 650px;
overflow: auto;
display: inline-block;
white-space: pre-wrap;
}
8 changes: 7 additions & 1 deletion dash-renderer/src/components/error/FrontEnd/FrontEndError.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ function UnconnectedErrorContent({error, base}) {
</div>
)}
{/* Backend Error */}
{typeof error.html !== 'string' ? null : (
{typeof error.html !== 'string' ? null : error.html.indexOf(
'<!DOCTYPE HTML'
) === 0 ? (
<div className="dash-be-error__st">
<div className="dash-backend-error">
{/* Embed werkzeug debugger in an iframe to prevent
Expand Down Expand Up @@ -140,6 +142,10 @@ function UnconnectedErrorContent({error, base}) {
/>
</div>
</div>
) : (
<div className="dash-be-error__str">
<div className="dash-backend-error">{error.html}</div>
</div>
)}
</div>
);
Expand Down