Skip to content

add color to list of val types which can be arrays in full reference pages #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

add color to list of val types which can be arrays in full reference pages #1119

merged 1 commit into from
Oct 23, 2018

Conversation

michaelbabyn
Copy link
Contributor

resolves #1114

@michaelbabyn michaelbabyn requested a review from cldougl October 5, 2018 18:26
@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Oct 5, 2018
@michaelbabyn michaelbabyn changed the title add color to list of val types which can be arrays in func-ref add color to list of val types which can be arrays in full reference pages Oct 9, 2018
cldougl
cldougl approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 23, 2018
@michaelbabyn michaelbabyn merged commit ea375d4 into source-design-merge Oct 23, 2018
@michaelbabyn michaelbabyn deleted the color_array_reference branch October 23, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldougl cldougl cldougl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bar.insidetextfont.color misses that it can be an array of color
2 participants
@michaelbabyn @cldougl