Skip to content

updated python latex doc #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

priyatharsan
Copy link
Contributor

@priyatharsan priyatharsan commented Feb 18, 2019

The plot may not render properly in FF due to this issue: plotly/plotly.js#3290
and the hover label issue: plotly/plotly.js#559

screenshot 8

@priyatharsan priyatharsan added the ReviewReady This PR is ready for review label Feb 18, 2019
@priyatharsan priyatharsan requested a review from cldougl February 18, 2019 20:50
@michaelbabyn
Copy link
Contributor

@priyatharsan, the code formatting looks better here than it did before the update but this PR doesn't really close #1258. Can you edit the first comment in this PR to remove the "closes 1258" reference and then manually close 1258 by citing that these are plotly.js bugs not documentation issues.

💃 for the PR though it's definitely an improvement

@priyatharsan
Copy link
Contributor Author

yeah that makes sense. Thanks for the review @michaelbabyn

@priyatharsan priyatharsan merged commit f3b9cd1 into source-design-merge Feb 28, 2019
@priyatharsan priyatharsan deleted the py-latex-doc-update branch February 28, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReviewReady This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants