Skip to content

Computed geom/stat params have changed location #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cpsievert opened this issue May 17, 2021 · 0 comments · Fixed by #1952
Closed

Computed geom/stat params have changed location #1951

cpsievert opened this issue May 17, 2021 · 0 comments · Fixed by #1952

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented May 17, 2021 •
edited
Loading

From Thomas, in the new (> 3.3.3) version of ggplot2:

we now store layer parameters in computed_geom_params and computed_stat_params which should be used everywhere that geom_params and stat_params are currently being used
cpsievert added a commit that referenced this issue May 17, 2021
@cpsievert
Close #1951: use computed_[geom/stat]_params over [geom/stat]_params …
e8aa8b0 
…if available
@cpsievert cpsievert mentioned this issue May 17, 2021
Merged
cpsievert added a commit that referenced this issue May 17, 2021
@cpsievert
Fixes for ggplot2 3.3.4 (#1952)
598120b 
* Close #1951: use computed_[geom/stat]_params over [geom/stat]_params if available

* Merge instead of combine layer and plot aes mappings

* update news
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for ggplot2 3.3.4 plotly/plotly.R
1 participant
@cpsievert