-
Notifications
You must be signed in to change notification settings - Fork 633
Fix axis facets #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix axis facets #1788
Conversation
…et panels with only one category.
Looks great, thank you! If you agree with the suggested change, please commit it and add a news item, then I'll merge BTW, have you tried to create and/or run visual tests? I think we can get away with not having one here, but it'd be great to have them in some of your other PRs |
Co-authored-by: Carson Sievert <[email protected]>
Just commited your changes and added a news item. Regarding the visual tests:
I also tried running the visual tests via docker ...
|
Hmm, are you in windows powershell? https://stackoverflow.com/a/51379726/1583084 |
(: Thanks a lot. It was the Powershell issue. Now the docker works like a charm. BTW: I also figured out my issue with visual testing inside RStudio. After running the tests via |
Ahh, yea, sorry, I should've mentioned before that the visual tests should only really only be run via docker |
This PR fixes a bug in
verify_attr
which closes #1720 and #1577 .Adding the fix the reprex from #1720 is rendered like so
and the reprex from #1577 like so: