Skip to content

Fix axis facets #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Fix axis facets #1788

merged 4 commits into from
Jun 17, 2020

Conversation

trekonom
Copy link
Contributor

@trekonom trekonom commented Jun 7, 2020

This PR fixes a bug in verify_attr which closes #1720 and #1577 .

Adding the fix the reprex from #1720 is rendered like so

grafik

and the reprex from #1577 like so:

grafik

@cpsievert
Copy link
Collaborator

Looks great, thank you! If you agree with the suggested change, please commit it and add a news item, then I'll merge

BTW, have you tried to create and/or run visual tests? I think we can get away with not having one here, but it'd be great to have them in some of your other PRs

@trekonom
Copy link
Contributor Author

Just commited your changes and added a news item.

Regarding the visual tests:

I also tried running the visual tests via docker ...

  • Following your instructions , i.e. running docker run -v $(pwd):/home/plotly --privileged -p 3838:3838 cpsievert/plotly-orca always resulted in the error invalid reference format.
  • But as I used docker for the first time maybe I simply got something wrong.

@cpsievert
Copy link
Collaborator

Hmm, are you in windows powershell? https://stackoverflow.com/a/51379726/1583084

@trekonom
Copy link
Contributor Author

(: Thanks a lot. It was the Powershell issue. Now the docker works like a charm. BTW: I also figured out my issue with visual testing inside RStudio. After running the tests via devtools::test() (as you suggested in the contributing guidelines) instead of pressing the "Run Tests" button my visual tests passed.

@cpsievert
Copy link
Collaborator

Ahh, yea, sorry, I should've mentioned before that the visual tests should only really only be run via docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ggplotly breaks discrete x-axis with facet_yyyy in panels > 1 with only one category
2 participants