solution for #463 plotly in ioslides #524
Conversation
Detected 3 differences -> http://cpsievert.github.io/plotly-test-table/9a71074/jitter-basic |
|
Nice! Those differences are false positives as well :) (they use random data, which I should really fix someday...) |
|
@timelyportfolio if you see Rserv started in daemon mode.
Error in socketConnection(host, port, open = "a+b", blocking = TRUE) :
cannot open the connectionin the build log, restarting the build usually fixes it (the pull request build spins up a child R session and runs tests against master in order to report the differences you see above ^^^) |
|
Also, in the future, if I give 👍 in a pull request, feel free to bump the version, update the NEWS file, and merge with master :) |
|
One more thing...feel free to put "fix #xyz" or "close #xyz" in the commit message so they'll automatically close for us |
Detected 3 differences -> http://cpsievert.github.io/plotly-test-table/26da373/jitter-basic |
solution for #463 plotly in ioslides
|
I just discovered this issue this week. Unfortunately this PR introduced an undesirable consequence: when you print ioslides to PDF, plotly widgets will be hidden unless they happen to be on the current slide. I just applied an alternative fix at rstudio/rmarkdown@8313bbe, and tested the example in #463. I hope this PR could be reverted after the next version of rmarkdown is released to CRAN. Thanks! |
…ly widgets I think plotly/plotly.R#524 should be reverted eventually because it essentially hides plotly widgets when printing ioslides to PDF (unless a widget happens to be on the current slide)
…ly widgets I think plotly/plotly.R#524 should be reverted eventually because it essentially hides plotly widgets when printing ioslides to PDF (unless a widget happens to be on the current slide)
This pull represents the most minimal solution possible to #463, so tooltips will appear in
ioslidespresentations. I tested with various examples in different contexts and did not notice any harmful regressions or side effects. Duplicates #523 to see if credentials work correctly with tests.