Better subplot interface #526

cpsievert · 2016-03-19T05:59:12Z

Stuff left to do:

Scale shapes/annotations appropriately. Here's a nice working example:

# once this is working well, we can wrap it up, and have a special build for 'ggmatrix' objects
pm <- GGally::ggpairs(reshape::tips[, 1:3])
plotList <- list()
for (i in seq_len(pm$nrow)) {
  for (j in seq_len(pm$ncol)) {
    plotList <- c(plotList, list(pm[i, j]))
  }
}
do.call(subplot, c(plotList, list(nrows = 3)))

Allow some way to specify column/row width. This would be potentially useful both for support space="free" in ggplot2 facets, as well as in Enchance subplot()'s ability to handle pre-specified domain(s) #376
Support subplots of subplots, for example subplot(plot_ly(), subplot(plot_ly(), plot_ly()))
Bring back support for geo subplots (should this be done via the new subplotid attribute?)

…ogic

cpsievert · 2016-03-24T05:47:12Z

@talgalili for the second todo item, I'm thinking of adding widths and heights arguments, a la, grid.arrange(). I also think it's most sensible to specify these on a 0-1 scale, so you could recreate that example (in #376) like this:

subplot(hist_top, empty, scatter, hist_right, nrows=2, widths=c(0.8, 0.2), heights=c(0.2, 0.8))

…with ggmatrix/ggplot methods

…ment to ggplotly()

cpsievert · 2016-05-16T03:25:36Z

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/130484030

Detected 38 differences ->

cpsievert · 2016-05-16T05:19:34Z

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/130495204

Detected 38 differences ->

cpsievert added 6 commits March 19, 2016 16:57

first stab at subplot rewrite

4521993

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

888999e

start thinking about shapes/annotations

c7098c7

reposition shapes/annotations

0dd4d63

add meta-info to identify axis titles; simplify facet strip drawing l…

72cb6b8

…ogic

safeguard against missing info

b6fb58e

cpsievert changed the title ~~first stab at subplot rewrite~~ Better subplot interface Mar 24, 2016

cpsievert added 19 commits March 24, 2016 17:51

safeguard against missing values in subplot; ggplotly is now generic …

70ca674

…with ggmatrix/ggplot methods

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

3fb6754

add plot title to subplot

d8f2f7a

merge with master

ab2de06

Implement widths/heights arguments

a45749c

add shareX/shareY arguments

a8c1628

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

9e2d138

fix test typo

c61675f

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

f8eedaa

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

4655d89

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

193ba4e

merge conflicts

eb9c080

make plotly_build a generic function

d10b5a9

add keep_titles argument

975733d

traces with missing axis object references should generate new plots

98dcd96

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

961e73d

better defaults; start on a vignette

79650d7

Remove keep_titles in favor of titleX/titleY

dee87c2

better sizing defaults

f342c0b

talgalili mentioned this pull request May 12, 2016

subplot() no longer seem to work with ggplotly objects (bug) #520

Closed

cpsievert added 2 commits May 13, 2016 17:09

Merge branch 'master' of github.com:ropensci/plotly into fix/subplot

a978fbc

subplot now accepts a list of plots

ab93d5a

cpsievert added 6 commits May 14, 2016 14:57

don't draw blank or interior facet strip in grid layout; add ... argu…

81bcdd5

…ment to ggplotly()

add to vignette; better check for list of plots

0020348

make code a bit more readable; improve axis sharing logic

8b15c00

improve ggplotly.ggmatrix logic

88591f6

moar subplot tests

b881917

supply defaults for geo

35ae74a

cpsievert added 4 commits May 16, 2016 15:01

cleanup

957923c

a few vignette edits

80007ac

bump version; update news

f1eee2b

fix typo; document

cd62ed5

cpsievert merged commit dd9a3fa into master May 16, 2016

cpsievert deleted the fix/subplot branch May 16, 2016 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better subplot interface #526

Better subplot interface #526

cpsievert commented Mar 19, 2016 •

edited

Loading

cpsievert commented Mar 24, 2016

cpsievert commented May 16, 2016

cpsievert commented May 16, 2016

Better subplot interface #526

Better subplot interface #526

Conversation

cpsievert commented Mar 19, 2016 • edited Loading

cpsievert commented Mar 24, 2016

cpsievert commented May 16, 2016

cpsievert commented May 16, 2016

cpsievert commented Mar 19, 2016 •

edited

Loading