Skip to content

Commit ab2b4fe

Browse files
committed
log entry for >60 input dimensions
1 parent 104c03f commit ab2b4fe

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Diff for: src/traces/parcoords/constants.js

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111

1212
module.exports = {
13+
maxDimensionCount: 60, // this cannot be increased without WebGL code refactoring
1314
overdrag: 45,
1415
legendWidth: 80,
1516
verticalPadding: 2, // otherwise, horizontal lines on top or bottom are of lower width

Diff for: src/traces/parcoords/defaults.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ var Lib = require('../../lib');
1212
var attributes = require('./attributes');
1313
var hasColorscale = require('../../components/colorscale/has_colorscale');
1414
var colorscaleDefaults = require('../../components/colorscale/defaults');
15+
var maxDimensionCount = require('./constants').maxDimensionCount;
1516

1617
var handleLineDefaults = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
1718

@@ -26,15 +27,17 @@ var handleLineDefaults = function lineDefaults(traceIn, traceOut, defaultColor,
2627
}
2728
};
2829

29-
3030
function dimensionsDefaults(traceIn, traceOut) {
3131
var dimensionsIn = traceIn.dimensions || [],
3232
dimensionsOut = traceOut.dimensions = [];
3333

3434
var dimensionIn, dimensionOut, i;
3535
var commonLength = Infinity;
3636

37-
dimensionsIn.splice(60); // parcoords supports up to this many dimensions
37+
if(dimensionsIn.length > maxDimensionCount) {
38+
Lib.log('parcoords traces support up to ' + maxDimensionCount + ' dimensions at the moment');
39+
dimensionsIn.splice(maxDimensionCount);
40+
}
3841

3942
function coerce(attr, dflt) {
4043
return Lib.coerce(dimensionIn, dimensionOut, attributes.dimensions, attr, dflt);

0 commit comments

Comments
 (0)