Skip to content

scatter3d zooms on scroll even if zoomScroll is false #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antoinerg opened this issue Sep 11, 2018 · 3 comments
Closed

scatter3d zooms on scroll even if zoomScroll is false #2998

antoinerg opened this issue Sep 11, 2018 · 3 comments
Labels
feature something new

Comments

@antoinerg
Copy link
Contributor

See codepen example: https://codepen.io/antoinerg/pen/YOaaaZ
@antoinerg antoinerg added the bug something broken label Sep 11, 2018
@etpinard
Copy link
Contributor

Old news, but true.

related: #143

@antoinerg antoinerg self-assigned this Sep 13, 2018
@etpinard
Copy link
Contributor

I don't think we should fix this bug (in v1.x at least), but instead we add a new a config option for 3D scroll zoom (and another for geo scroll zoom).

Why?

  • 3D and geo subplots don't offer another way to zoom into subplot other than scrolling. In other words, scroll zoom isn't as "optional" as for cartesian graphs
  • the scrollZoom default is currently false, so enforcing that scrollZoom default in 3D and geo subplots would be a breaking change (unless we add some fancy hacky logic to override the scrollZoom default whenever 3D and geo subplots are present on the graph, but this sounds like a nigthmare).

@antoinerg antoinerg removed their assignment Sep 18, 2018
@etpinard etpinard added feature something new and removed bug something broken labels Sep 25, 2018
@alexcjohnson alexcjohnson mentioned this issue Nov 16, 2018
Closed
5 tasks
etpinard added a commit that referenced this issue Jan 8, 2019
@etpinard
resolves #2998 - implement scrollZoom:false for gl3d subplots
0e958d1
etpinard added a commit that referenced this issue Jan 8, 2019
@etpinard
resolves #2998 - implement scrollZoom:false for gl3d subplots
26618dd
@etpinard etpinard mentioned this issue Jan 8, 2019
Merged
@etpinard
Copy link
Contributor

done in #3422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoinerg @etpinard