Skip to content

Polar bargap looks invalid to Plotly.validate #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Sep 18, 2018 · 1 comment
Closed

Polar bargap looks invalid to Plotly.validate #3022

alexcjohnson opened this issue Sep 18, 2018 · 1 comment
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

I made this plot:

Plotly.newPlot(gd,[
  {type:'barpolar',r:r,theta:th,marker:{color:c,colorscale:'Jet'},subplot:'polar2'},
  {type:'scatterpolar',mode:'markers',theta:mth,r:mr,marker:{size:ms,color:mc,colorscale:[[0,'#600'],[1,'#f00']],sizeref:0.3}}
], {
  polar2: {domain:{x:[0,1],y:[0,1]},bargap:0.5,hole:0.83,radialaxis:{visible:false},angularaxis:{ticks:'',showline:false,nticks:40}},
  polar: {bgcolor:'#d3d3d3',hole:0.2,domain:{x:[0.1,0.9],y:[0.1,0.9]},
    radialaxis:{gridcolor:'#fff',showline:false,showticklabels:false,ticks:''},
    angularaxis:{gridcolor:'#fff',nticks:40,showline:false,ticks:'',showticklabels:false}}
})

But although it works correctly, Plotly.validate complains:

Plotly.validate(gd.data, gd.layout)
LOG: In layout, key polar2.bargap is not part of the schema

@etpinard comments:

ah right, that's a first
a trace layout attribute inside a subplot container

(cc @Kully - you can ignore that one if you run Plotly.validate)

@alexcjohnson alexcjohnson added the bug something broken label Sep 18, 2018
etpinard added a commit that referenced this issue Sep 18, 2018
... during validation.

This solution is not-strict as it could be, but at least fixes
the false-negative case of #3022.
@Kully
Copy link
Contributor

Kully commented Sep 18, 2018

Plotly.validate(gd.data, gd.layout)
LOG: In layout, key polar2.bargap is not part of the schema

and as I would expect, we get the same LOG for nested properties i.e. polar.angularaxis.orientation and polar.angularaxis.domain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants