Add a nice error message when people animate before plotting #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Oct 26, 2016
| @@ -2156,7 +2156,11 @@ Plotly.animate = function(gd, frameOrGroupNameOrFrameList, animationOpts) { | |||
| gd = helpers.getGraphDiv(gd); | |||
|
|
|||
| if(!Lib.isPlotDiv(gd)) { | |||
| throw new Error('This element is not a Plotly plot: ' + gd); | |||
| throw new Error( | |||
| 'This element is not a Plotly plot: ' + gd + '. It\'s likely that you\'ve failed ' + | |||
There was a problem hiding this comment.
We should really start putting all these error messages in a some src/constants/ file.
But, for now, this is great !
There was a problem hiding this comment.
Agreed. I think it'd be nice in general to beef up the error messages, particularly when the input looks fishy—like passing an object where an an array is expected and instead of failing it just doesn't get any props from it.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands on the current bad div message:
with more info:
Which people who are used to other libraries will probably run into very quickly. See: http://stackoverflow.com/questions/39415791/using-plotly-js-animation-feature/39457872#39457872