Skip to content

add fallback in autobin routine #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2017
Merged

add fallback in autobin routine #1284

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c93dcb1
add fallback in autobin routine
etpinard Jan 6, 2017
755c143
make size0 fallback to 1,
etpinard Jan 9, 2017
5ad606f
add Axes.autoBin tests
etpinard Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,11 @@ axes.autoBin = function(data, ax, nbins, is2d, calendar) {
distinctData.minDiff / msexp, [0.9, 1.9, 4.9, 9.9], true);
size0 = Math.max(minSize, 2 * Lib.stdev(data) /
Math.pow(data.length, is2d ? 0.25 : 0.4));

// fallback if ax.d2c output BADNUMs
// e.g. when user try to plot categorical bins
// on a layout.xaxis.type: 'linear'
if(!isNumeric(size0)) size0 = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a bin size of 0 made it through, this could lead to infinite loops or divide-by-zero errors somewhere else. It looks like Axes.autoTicks has its own fallback for this so dummyAx.dtick won't be zero, which is why this works for now, but perhaps it would be better to use size0 = 1 instead so we don't have to depend on this behavior from autoTicks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 755c143

}

// piggyback off autotick code to make "nice" bin sizes
Expand Down