Skip to content

Bump dev deps #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2017
Merged

Bump dev deps #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80e2ea4
bump dev deps
etpinard Feb 17, 2017
2998a0a
throw error on process exit,
etpinard Feb 17, 2017
2b57297
bump MAX_ALLOWED_CIRCULAR_DEPS to 18
etpinard Feb 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,34 +94,34 @@
},
"devDependencies": {
"brfs": "^1.4.3",
"browserify": "^13.3.0",
"browserify": "^14.1.0",
"browserify-transform-tools": "^1.7.0",
"deep-equal": "^1.0.1",
"ecstatic": "^2.1.0",
"eslint": "^3.13.0",
"eslint": "^3.15.0",
"falafel": "^2.0.0",
"fs-extra": "^1.0.0",
"fs-extra": "^2.0.0",
"fuse.js": "^2.6.1",
"glob": "^7.0.0",
"gzip-size": "^3.0.0",
"image-size": "^0.5.1",
"jasmine-core": "^2.4.1",
"karma": "^1.1.0",
"karma-browserify": "^5.0.1",
"karma": "^1.4.1",
"karma-browserify": "^5.1.1",
"karma-chrome-launcher": "^2.0.0",
"karma-coverage": "^1.0.0",
"karma-firefox-launcher": "^1.0.0",
"karma-jasmine": "^1.1.0",
"madge": "^1.4.4",
"node-sass": "^4.1.1",
"madge": "^1.6.0",
"node-sass": "^4.5.0",
"npm-link-check": "^1.2.0",
"open": "0.0.5",
"prepend-file": "^1.3.1",
"prettysize": "0.0.3",
"requirejs": "^2.3.1",
"through2": "^2.0.3",
"uglify-js": "^2.7.5",
"watchify": "^3.8.0",
"watchify": "^3.9.0",
"xml2js": "^0.4.16"
}
}
18 changes: 13 additions & 5 deletions tasks/test_syntax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ var libGlob = path.join(constants.pathToLib, '**/*.js');
var testGlob = path.join(constants.pathToJasmineTests, '**/*.js');
var bundleTestGlob = path.join(constants.pathToJasmineBundleTests, '**/*.js');

var EXIT_CODE = 0;

// main
assertJasmineSuites();
assertSrcContents();
Expand Down Expand Up @@ -117,7 +119,7 @@ function assertCircularDeps() {
// as of v1.17.0 - 2016/09/08
// see https://github.com/plotly/plotly.js/milestone/9
// for more details
var MAX_ALLOWED_CIRCULAR_DEPS = 17;
var MAX_ALLOWED_CIRCULAR_DEPS = 18;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #236 (comment)


if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
logs.push('some new circular dependencies were added to src/');
Expand All @@ -133,9 +135,15 @@ function combineGlobs(arr) {

function log(name, logs) {
if(logs.length) {
console.error('test-syntax error [' + name + ']\n');
throw new Error('\n' + logs.join('\n') + '\n');
console.error('test-syntax error [' + name + ']');
EXIT_CODE = 1;
} else {
console.log('ok ' + name);
}

console.log('ok ' + name);
}

process.on('exit', function() {
if(EXIT_CODE) {
throw new Error('test syntax failed.');
}
});