Fix overlaying subplot configuration relayouts #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was only used for scattergl and now scattergl is plotted on 'cartesian' subplots.
- to clean what need to be cleaned up in exit selection, instead of using granular and brittle old vs new plotinfo logic - axis.layer, overlays are currently include, we might want to include more things in it eventually,
- now 'd' is an array, and the subplot id is in d[0].
- this should never have been part of Plots.supplyDefaults pipeline.
|
Lovely. Nice bug fix and a structural step in the right direction to boot! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2828 and moves a few "clean up old layer" blocks out of
Plots.supplyDefaultsand intoCartesian.drawFramework(cc #2549).cc @alexcjohnson @nicolaskruchten