Skip to content

Heatmap ordering bug #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 17, 2018
Merged

Heatmap ordering bug #2917

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d553142
fix dynamic heatmap ordering
alexcjohnson Aug 16, 2018
8faefde
fix dynamic ordering of carpets, and :hocho: getUidsFromCalcData
alexcjohnson Aug 16, 2018
4e01efe
DRY trace group management for (nearly) all cartesian traces
alexcjohnson Aug 17, 2018
b0693da
updated baseline images
alexcjohnson Aug 17, 2018
07aee8f
:hocho: obsolete setClipUrl on contour heatmap fill
alexcjohnson Aug 17, 2018
69dee75
refactor make_trace_groups to more general lib function
alexcjohnson Aug 17, 2018
e892923
fix ordering for choropleths
alexcjohnson Aug 17, 2018
9ddad4c
use makeTraceGroups in pie
alexcjohnson Aug 17, 2018
521d27f
fix ordering for scattergeo
alexcjohnson Aug 17, 2018
d295d36
oops - put scattergeo in the right container
alexcjohnson Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/traces/contour/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,6 @@ function clipGaps(plotGroup, plotinfo, clips, cd0, perimeter) {
else clipId = null;

plotGroup.call(Drawing.setClipUrl, clipId);
plotinfo.plot.selectAll('.hm' + cd0.trace.uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

.call(Drawing.setClipUrl, clipId);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, GH is working again with these images, must've been an internal glitch last night.

The reason for the image diffs is that in master (right) we were applying the clip-path to both the heatmap group and the contour group... and now that the heatmap is inside the contour group that was redundant but apparently it was still having an effect on antialiasing. The Drawing.setClipUrl here that was supposed to be clipping the heatmap actually wasn't doing anything, since I removed the uid-based class from the heatmap.
screen shot 2018-08-17 at 9 59 51 am
So in fact the image diff in this PR probably nearly (or exactly) reverts the diff from contour-legend https://github.com/plotly/plotly.js/pull/2891/files?short_path=2b47456#diff-2b474566a55f847908961b61d6e0cba4

}

function makeClipMask(cd0) {
Expand Down