Skip to content

scatter3d display errorbars when error_z is not specified #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2018
Merged

scatter3d display errorbars when error_z is not specified #3011

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ffb898
scatter3d errorbars now fallback to default attributes if error_z is …
antoinerg Sep 13, 2018
12b8aa1
scatter3d error bars add baseline
antoinerg Sep 14, 2018
b9ec1f6
scatter3d use error bars' defaults values when possible
antoinerg Sep 14, 2018
7542e6f
scatter3d errorbars update baselines
antoinerg Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/traces/scatter3d/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ var DASH_PATTERNS = require('../../constants/gl3d_dashes');
var MARKER_SYMBOLS = require('../../constants/gl3d_markers');

var calculateError = require('./calc_errors');
var errorBarsAttributes = require('../../components/errorbars/attributes');

function LineWithMarkers(scene, uid) {
this.scene = scene;
Expand Down Expand Up @@ -124,9 +125,9 @@ function calculateErrorParams(errors) {
if(e && e.copy_zstyle !== false) e = errors[2];
if(!e) continue;

capSize[i] = e.width / 2; // ballpark rescaling
capSize[i] = (e.width || 0) / 2; // ballpark rescaling
color[i] = str2RgbaArray(e.color);
lineWidth = e.thickness;
lineWidth = (e.thickness || errorBarsAttributes.thickness.dflt);
Copy link
Contributor

@etpinard etpinard Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Strange, judging from

plotly.js/src/components/errorbars/defaults.js

Line 71 in e545415

coerce('thickness');

fullData[i].thickness should have a set value by the time it gets here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that having values set in fullData is (very) important for the react-chart-editor (aka RCE). RCE uses fullData to fill in its UI components.


}

Expand Down
Binary file added test/image/baselines/gl3d_errorbars_xy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions test/image/mocks/gl3d_errorbars_xy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"data": [{
"type": "scatter3d",
"mode": "markers",
"x": [1],
"y": [1],
"z": [1],
"error_x": {
"type": "sqrt",
"thickness": 5
},
"error_y": {
"type": "sqrt",
"thickness": 5,
"color": "red"
}
}],
"layout": {}
}