-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add 'width' to box and violin trace #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from 36 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
8f04d13
added vwidth param - not working
Coding-with-Adam f76ca97
update dPos with vwidth//remove most console.logs
Coding-with-Adam 81cdbe9
some revision based on review comments
Coding-with-Adam 5ef2eeb
change dflt vwidth to 0;assign dPos for each trace
Coding-with-Adam 1c6b26b
vwidth is now the half width // padding now uses trace.width values i…
Coding-with-Adam 2d93a0e
vwidth to width
Coding-with-Adam 1f9ced8
compact the t.dPos assignment with trace.width
Coding-with-Adam 26f44c4
change location of width attribute description to be consistent with …
Coding-with-Adam 77b9c9d
more complete descriptions
Coding-with-Adam 243a369
add 1 image test
Coding-with-Adam eb5e9da
add new line to joyplot mock file
Coding-with-Adam eea273b
camelCase
Coding-with-Adam 408aacb
zapped trailing ',' in box/violin attributes
Coding-with-Adam 0555283
do not coerce scale{mode, group} if no width; otherwise set to dflt v…
Coding-with-Adam 4eb8b44
first pass at calculating extreames for each trace
Coding-with-Adam 44e0a88
fix up the syntax of violin/defaults
Coding-with-Adam f8b963b
remove old baseline png
Coding-with-Adam 54aa355
generated updated joyplot baseline image
Coding-with-Adam 0d4239b
remove padding depending on trace.side//regen baseline
Coding-with-Adam fa3a314
fix space syntax error
Coding-with-Adam c63780f
...
Coding-with-Adam c24330d
update algo for padding
Coding-with-Adam 6e7883d
fix test syntax
Coding-with-Adam 37786d6
remove consolve logs
Coding-with-Adam 45ae47d
update kde line test
Coding-with-Adam 8366c88
more testing with jasmine
Coding-with-Adam ce81377
remove commented lines
Coding-with-Adam 8885b5e
remove another commented line and a useless loop
Coding-with-Adam 57cc05a
remove maxHalfWidth var
Coding-with-Adam fe3d7ed
cleaner code for vpad assignment
Coding-with-Adam 44fa269
inherit violin 'width' from box.width
etpinard f5ba38c
rm useless attrs in test mock
etpinard 34722d3
mention that 'width' is in data coordinates
etpinard d1aed48
ignore box/violin *gap and *groupgap when 'width' is set
etpinard c70f7d5
do not coerce scale* attrs when violin 'width' is set
etpinard 0dea0e9
Merge pull request #3222 from plotly/joyplots-etpinard
Kully 5e5f9ee
vpadplus and minus dont cut off jitter:0 points on violin
Coding-with-Adam d04c60c
Merge branch 'joyplots' of https://github.com/plotly/plotly.js into j…
Coding-with-Adam 91497e5
fix incorrect var name
Coding-with-Adam 657848f
small syntax - infix operator spacing
Coding-with-Adam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
{ | ||
"data": [{ | ||
"type": "violin", | ||
"width": 0.4, | ||
"name": "width: 0.4", | ||
"x": [0, 5, 7, 8], | ||
"side": "positive", | ||
"line": { | ||
"color": "black" | ||
}, | ||
"fillcolor": "#8dd3c7", | ||
"opacity": 0.6, | ||
"y0": 0.0 | ||
}, { | ||
"type": "violin", | ||
"name": "auto", | ||
"x": [0, 5, 7, 8], | ||
"side": "positive", | ||
"line": { | ||
"color": "black" | ||
}, | ||
"fillcolor": "#d3c78d", | ||
"opacity": 0.6, | ||
"y0": 0.1 | ||
}, { | ||
"type": "box", | ||
"width": 0.6, | ||
"name": "width: 0.6", | ||
"x": [0, 5, 7, 8], | ||
"side": "positive", | ||
"line": { | ||
"color": "black" | ||
}, | ||
"fillcolor": "#c78dd3", | ||
"opacity": 0.6, | ||
"y0": 0.2 | ||
}], | ||
"layout": { | ||
"title": "Joyplot - Violin with multiple widths", | ||
"legend": {"x": 0}, | ||
"xaxis": {"zeroline": false}, | ||
"yaxis": {"dtick": 0.1, "gridcolor": "black"} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anything break if we 🔪 the
else
entirely? Unnecessary attributes should simply not be included intraceOut
at all.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the violins are not drawn properly: the outlines are filled with black ink