Bug fix - adjust tick distances in perspective views #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2018
archmoj
commented
Dec 5, 2018
package.json
Outdated
| @@ -78,7 +78,7 @@ | |||
| "gl-mat4": "^1.2.0", | |||
| "gl-mesh3d": "^2.0.2", | |||
| "gl-plot2d": "^1.4.0", | |||
| "gl-plot3d": "^1.6.0", | |||
| "gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#417c23ae4e17476114ed02cdca3e8ddd0b417d1d", | |||
|
This looks great! Could you turn you demo "data"/"layout" into a new gl3d mock? |
|
This looks great! Could you turn your demo "data"/"layout" into a new gl3d mock? |
|
Thanks for the review. I could easily create the new mock. |
|
💃 here and for the associated gl-plot3d and gl-axes3d PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3302 by taking into account all the data in front of the camera (only near clipping applied & not left, right, top, bottom, far perspective planes).
This new demo could be used to interactively test the new behaviour compared to the previous demo.
Also required to then address #3306, #3155 & #2646.
@etpinard
@alexcjohnson