Skip to content

Eslint 1tbs help update else statement blocks #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2019
Merged

Eslint 1tbs help update else statement blocks #3757

merged 3 commits into from
Apr 11, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 11, 2019

Follow up of #3162 (comment) & #3162 (comment),
a new lint rule is applied in this PR.

@plotly/plotly_js

@etpinard
Copy link
Contributor

Like I said in #3162 (comment), I'm a fan of this new rule, but perhaps we should let @plotly/plotly_js come to consensus first.

@antoinerg
Copy link
Contributor

I don't have a strong opinion on which linting rules we should adopt. If both @etpinard and @archmoj like it better, we should adopt it!

@etpinard
Copy link
Contributor

Alright, let's get this in 💃

@archmoj archmoj merged commit df35b38 into master Apr 11, 2019
@archmoj archmoj deleted the eslint-1tbs-fix-all-else branch April 11, 2019 20:47
@archmoj archmoj mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @etpinard @antoinerg