fix svgTextUtils for FF: use child element instead of SVG to getSize() #3783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2616
The fix was tested in
Mozilla Firefox 62.0.3
in Linux. I try to fix the following misbehaving routine in FF:plotly.js/src/lib/svg_text_utils.js
Lines 22 to 24 in fe842c4
However, after inspecting the DOM in Firefox, it turns out that it sets the size of the embedded
svg.gtitle-math
elements to a very large value. However, it sizes properly its first and only child element. We use this one instead when callinggetSize()
.Codepen before: https://codepen.io/antoinerg/pen/oOEaPz
Codepen after: https://codepen.io/antoinerg/pen/ZZrqmd
Before:


After: