Skip to content

Fix steps in indicator attributes mock #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Fix steps in indicator attributes mock #4740

merged 1 commit into from
Apr 7, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 7, 2020

Supersedes #4738.
The steps should be a list.

@plotly/plotly_js
cc: @hmf

@archmoj archmoj added bug something broken status: reviewable labels Apr 7, 2020
@archmoj archmoj requested a review from antoinerg April 7, 2020 13:43
@archmoj archmoj mentioned this pull request Apr 7, 2020
Closed
alexcjohnson
alexcjohnson approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 yep, nice to have that feature tested for real rather than accidentally failing!

@archmoj archmoj added type: maintenance and removed bug something broken labels Apr 7, 2020
@archmoj archmoj merged commit ef15502 into master Apr 7, 2020
@archmoj archmoj deleted the fix-steps-indicator_attrs branch April 7, 2020 13:57
@nicolaskruchten
Copy link
Contributor

Yep! I just didn't want to make @hmf feel like he had to go through the whole "regenerate the baselines" thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@antoinerg antoinerg Awaiting requested review from antoinerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @nicolaskruchten @alexcjohnson