Apply and ensure stroke event only to activate editable shapes #4810
Conversation
…e editable shapes
archmoj
added
bug
src/components/shapes/draw.js
Outdated
| @@ -163,15 +168,11 @@ function drawOne(gd, index) { | |||
| } else { | |||
| if(gd._context.edits.shapePosition) { | |||
| setupDragElement(gd, path, options, index, shapeLayer, editHelpers); | |||
| } else { | |||
| if(options.editable === true) { | |||
| path.style('pointer-events', 'stroke'); | |||
There was a problem hiding this comment.
As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.
| } | ||
| } | ||
| ] | ||
| }, onfig: { |
There was a problem hiding this comment.
| }, onfig: { | |
| }, config: { |
There was a problem hiding this comment.
Fantastic! Just one little typo to fix and this should be ready! 💃
|
@archmoj re:
do we need to change one of the schema attribute descriptions to match this? I can't remember. |
@nicolaskruchten |
Fixes #4806 and fixes #4808
also now one could strat drawing over shapes no matter what the opacity of the below shape is.Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv
@plotly/plotly_js
@emmanuelle