Skip to content

Bump fuse.js v6 #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020
Merged

Bump fuse.js v6 #4882

merged 2 commits into from
May 28, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 28, 2020

@plotly/plotly_js

// location: 0,
// threshold: 0.6,
// distance: 100,
// useExtendedSearch: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments here for a reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply taken from fuse.js docs, illustrating options and their defaults.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 after minor question re: comments.

@archmoj archmoj merged commit 5b8b1db into master May 28, 2020
@archmoj archmoj deleted the bump-fuse.js branch May 28, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants