Skip to content

Bump events to v3 in glslify-deps #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Bump events to v3 in glslify-deps #5297

merged 2 commits into from
Nov 30, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Nov 20, 2020

Addressing #5289 (comment)

@plotly/plotly_js
cc: @rreusser

@rreusser
Copy link
Contributor

I released v1.3.2 of glslify-deps. Glslify has a dependency on ^1.2.5, which means it should automatically increment the minor version. I double checked by npm installing glslify and confirming that it pulls in [email protected] and passes the tests.

https://github.com/glslify/glslify/blob/ba9c52c46e10068215290753e99ac516cc02d0d7/package.json#L29

Let me know if any other action is required, otherwise I think this should do the trick.

@archmoj
Copy link
Contributor Author

archmoj commented Nov 25, 2020

bump-glslify-deps

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 5700db2 into master Nov 30, 2020
@archmoj archmoj deleted the bump-events-in-glslify branch November 30, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants