Skip to content

Heatmap: Fix render bug when zsmooth: 'fast' #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2016
Merged

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented May 17, 2016

Ain't nothin like a Tuesday afternoon oneliner 🎉

Fixes #530

In brief:

  • change for loop to iterate the correct number of times for the width of the heatmap
  • change the zsmooth for an existing image test

zsmooth_methods

@mdtusz mdtusz added bug something broken status: reviewable labels May 17, 2016
@etpinard
Copy link
Contributor

Nice 🍻

As I pointed out in #530 (comment), we currently don't have any image test mocks for zsmooth: 'fast'.

@mdtusz would you mind coming up with a three-subplot mocks showing off the three zsmooth values side-by-side for the same z data and add it to this PR?

@mdtusz mdtusz force-pushed the heatmap-zsmooth-bug branch from f435032 to 0ca4b3a Compare May 18, 2016 15:42
{
"data": [
{
"z": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@etpinard
Copy link
Contributor

💃

@mdtusz mdtusz merged commit 970d479 into master May 18, 2016
@mdtusz mdtusz deleted the heatmap-zsmooth-bug branch May 18, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants