Zoomscroll fix #564
Merged
Zoomscroll fix #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| el.attr('transform', 'scale(0, 0); rotate(30)'); | ||
| Lib.setScale(el, 30, 40); | ||
| expect(el.attr('transform')).toBe('rotate(30) scale(30, 40)'); |
| scale = Lib.getScale(mockEl); | ||
|
|
||
| expect([translate.x, translate.y]).toBeCloseToArray([62.841, 99.483]); | ||
| expect([scale.x, scale.y]).toBeCloseToArray([1.221, 1.221]); |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes #528. There was a regression when the last remaining nested
<svg>tags were removed, so that when zooming with a scroll, the transforms were incorrect.In brief:
Lib.getScale/Lib.setScalesimilar toLib.getTranslate/Lib.setTranslatemouseEvent('scroll', 100, 100, { deltaX: 0, deltaY: -500 })relayoutis called 50ms after the scroll is done, we need to "catch" the transformation (or alternatively we could use spies, but this seemed much simpler and will catch issues just the same)