Fix unknown filename when exporting charts using new versions of Safari #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ri, and it appears that recent versions may not need it
Fix Safari Download
archmoj
added
bug
archmoj
changed the title
test/jasmine/tests/download_test.js
Outdated
|
|
||
| it('should produce right output in Safari', function(done) { | ||
| /* | ||
| it('should produce right output in Old Safari', function(done) { |
There was a problem hiding this comment.
Do we really want to keep these commented-out tests around? Unless you want to try and mock canUseSaveLink===false - which I don't really think is worth it at this point - I'd just delete them.
alexcjohnson
approved these changes
Jul 20, 2021
|
✨ works for me on Safari 13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1227.
Follow up for PR #5609 thanks to @rlreamy
@plotly/plotly_js