Output bounding box to hover event data (new attempt) #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Aug 3, 2021
xhluca
force-pushed
the
external-hover-3
branch
from
2083dfb to
3533631
Compare
|
Thanks for the heads up. I removed the content of |
archmoj
reviewed
Aug 23, 2021
| // TODO: These coordinates aren't quite correct and don't take into account some offset | ||
| // I still haven't quite located (similar to xa._offset) | ||
| bbox: { | ||
| x0: pt.x0, |
There was a problem hiding this comment.
Are these coordinates correct for pie?
archmoj
reviewed
Aug 23, 2021
| // a sibling of the graph div, it will be positioned correctly relative to | ||
| // the offset parent, whatever that may be. | ||
| var hot = gd.offsetTop + gd.clientTop; | ||
| var hol = gd.offsetLeft + gd.clientLeft; |
There was a problem hiding this comment.
Let's rename hot and hol to topOffset and leftOffset.
|
Please update the PR description similar to #5512 and mention that PR. |
|
Please pull |
|
Please also provide |
|
@alexcjohnson can you help get this one over the finish line plz, even after @xhlulu leaves? :) |
|
No remarkable commit added when compared to the original PR #5512. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your interest in plotly.js!
Translations:
lib/locales/, not those indist/Features, Bug fixes, and others:
Before opening a pull request, developer should:
masterbranch of their fork as usingmasterfor a pull request would make it difficult to fetchupstreamchanges.upstream/masterinto your fork i.e.origin/masterthen pullorigin/masterfrom you localmaster.git rebase mastertheir local dev branch off the latestmasterwhich should be sync withupstream/masterat this time.git addthedist/folder (thedist/is updated only on version bumps).package-lock.jsonfile (if any new dependency required).After opening a pull request, developer:
1010_fix.mdor1010_add.mdinsidedraftlogsfolder as described in this README, commit it and push.git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetchupstream/masterand "merge" with master instead of "rebase".