Skip to content

Avoid attaching selections to missing eventData #6260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2022
Merged

Avoid attaching selections to missing eventData #6260

merged 3 commits into from
Jul 14, 2022
+9 −4

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 14, 2022

Fixes #6259.

@plotly/plotly_js

@archmoj
fix issue 6259 - handle missing eventData, layout and selections

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5a50ff0
@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jul 14, 2022
alexcjohnson
alexcjohnson approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM! If you also want to make the selected event only emitted in a select dragmode, fine, but if this makes the dash tests pass that's sufficient and we can address the other part later.

@archmoj archmoj merged commit 0f43d33 into master Jul 14, 2022
@archmoj archmoj deleted the fix-6259 branch July 14, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson

Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set properties of undefined (setting 'selections')
2 participants
@archmoj @alexcjohnson