Code

Mult axis formatting#6334

Code

Merged

hannahker merged 63 commits intomasterplotly/plotly.js:masterfrom mult-axis-formattingplotly/plotly.js:mult-axis-formattingCopy head branch name to clipboardDec 22, 2022

Commits

Commits on Sep 29, 2022

• Add shift parameter and set defaults accordingly

  hannahker

  committed
  e4a81e3

  Copy full SHA for e4a81e3

• Set defaults

  hannahker

  committed
  de79261

  Copy full SHA for de79261

Commits on Oct 3, 2022

• Simplify logic

  hannahker

  committed
  18f21cb

  Copy full SHA for 18f21cb

• Fix coercion logic

  hannahker

  committed
  0e85776

  Copy full SHA for 0e85776

Commits on Oct 4, 2022

• Include shift logic during drawing

  hannahker

  committed
  ba0c587

  Copy full SHA for ba0c587

• Add baseline image and fix syntax for tests

  hannahker

  committed
  2731eb8

  Copy full SHA for 2731eb8

• Fixes for tests

  hannahker

  committed
  c535c56

  Copy full SHA for c535c56

Commits on Oct 5, 2022

• Update plot schema

  hannahker

  committed
  a8fcadc

  Copy full SHA for a8fcadc

• Fix syntax

  hannahker

  committed
  0f93feb

  Copy full SHA for 0f93feb

• pass axShifts in opts & bypass undefined axShifts

  archmoj

  committed
  d79ef96

  Copy full SHA for d79ef96

• Shift axis line if applicable

  hannahker

  committed
  b1d10c5

  Copy full SHA for b1d10c5

Commits on Oct 6, 2022

• Add new mocks and set default position according to overlaying domain

  hannahker

  committed
  3fa0f0c

  Copy full SHA for 3fa0f0c

• Shift axes according to overlaying group

  hannahker

  committed
  50fe1fd

  Copy full SHA for 50fe1fd

• Clean up code to increment shifts

  hannahker

  committed
  1984b7e

  Copy full SHA for 1984b7e

Commits on Oct 13, 2022

• Set shift valType to any

  hannahker

  committed
  b9c77b8

  Copy full SHA for b9c77b8

• Add jasmine tests for defaults and update baselines

  hannahker

  committed
  8a420d6

  Copy full SHA for 8a420d6

• Fix syntax

  hannahker

  committed
  8d0c9eb

  Copy full SHA for 8d0c9eb

Commits on Oct 14, 2022

• Enable numeric shift values

  hannahker

  committed
  5528a35

  Copy full SHA for 5528a35

• Fix zerolines bug

  hannahker

  committed
  fbdc5a4

  Copy full SHA for fbdc5a4

• Fix logic in shift values

  hannahker

  committed
  d742cc5

  Copy full SHA for d742cc5

• Push axis to layout in jasmine test and add baseline

  hannahker

  committed
  c2ba6b0

  Copy full SHA for c2ba6b0

• Fix syntax

  hannahker

  committed
  cb66b12

  Copy full SHA for cb66b12

• Add more jasmine tests for defaults relative to shift

  hannahker

  committed
  38f17b2

  Copy full SHA for 38f17b2

Commits on Oct 21, 2022

• Fix bugs with scroll and drag interactions

  hannahker

  committed
  bbf682f

  Copy full SHA for bbf682f

• Simplify syntax

  hannahker

  committed
  0175979

  Copy full SHA for 0175979

Commits on Oct 24, 2022

• Adjust mock to have variable axis sizes

  hannahker

  committed
  7a1c9d8

  Copy full SHA for 7a1c9d8

Commits on Oct 27, 2022

• Set axis shift after drawing

  hannahker

  committed
  5aee58b

  Copy full SHA for 5aee58b

Commits on Nov 2, 2022

• Push out axes by estimated depth

  hannahker

  committed
  fd098a9

  Copy full SHA for fd098a9

Commits on Nov 4, 2022

• Move axis line drawing to axes file

  hannahker

  committed
  79c2c74

  Copy full SHA for 79c2c74

• Avoid drawing lines when not necessary

  hannahker

  committed
  bc9bfa2

  Copy full SHA for bc9bfa2

Commits on Nov 8, 2022

• Calculate depth without axis titles

  hannahker

  committed
  5ffbdd2

  Copy full SHA for 5ffbdd2

Commits on Nov 10, 2022

• Remove arrow functions

  hannahker

  committed
  168b3db

  Copy full SHA for 168b3db

• Fix failing dragbox test and mock validation

  hannahker

  committed
  472efb9

  Copy full SHA for 472efb9

• Add hard coded padding and titles to axes

  hannahker

  committed
  0c33429

  Copy full SHA for 0c33429

• Remove whitespace

  hannahker

  committed
  83e7f82

  Copy full SHA for 83e7f82

• Replace mocks

  hannahker

  committed
  6e71f53

  Copy full SHA for 6e71f53

Commits on Nov 17, 2022

• Merge pull request #6357 from plotly/mult-axis-formatting-depth

  Show description for 28eadb0
  hannahker

  authored
  28eadb0

  Copy full SHA for 28eadb0

Commits on Dec 5, 2022

• Revert changes to axis line drawing

  hannahker

  committed
  6d5ecb5

  Copy full SHA for 6d5ecb5

• Merge branch 'master' into mult-axis-formatting

  hannahker

  committed
  2b951fd

  Copy full SHA for 2b951fd

Commits on Dec 9, 2022

• Properly account for axis title positioning

  hannahker

  committed
  f97f27c

  Copy full SHA for f97f27c

• Fix syntax and add updated mocks

  hannahker

  committed
  de4dd05

  Copy full SHA for de4dd05

• Make sure that the axes redraw with dragbox still works

  hannahker

  committed
  38d3e71

  Copy full SHA for 38d3e71

• Account for case where title fits inside axis labels

  hannahker

  committed
  683d0f3

  Copy full SHA for 683d0f3

Commits on Dec 14, 2022

• Simplify syntax with feedback

  hannahker

  committed
  eca5d4f

  Copy full SHA for eca5d4f

Commits on Dec 15, 2022

• Update baselines with smaller padding

  hannahker

  committed
  b84f89d

  Copy full SHA for b84f89d

• Add jasmine test for axis positioning

  hannahker

  committed
  5f2240f

  Copy full SHA for 5f2240f

• Fix syntax

  hannahker

  committed
  81b661f

  Copy full SHA for 81b661f

Commits on Dec 16, 2022

• Simplify function call

  hannahker

  committed
  ec1f855

  Copy full SHA for ec1f855

Commits on Dec 19, 2022

• Redraw if needed based on shift param

  hannahker

  committed
  e56020d

  Copy full SHA for e56020d

• Add baseline for new mock and fix syntax

  hannahker

  committed
  b8bfab5

  Copy full SHA for b8bfab5

Commits on Dec 20, 2022

• Merge branch 'master' into mult-axis-formatting

  hannahker

  committed
  b41678c

  Copy full SHA for b41678c

• Rename redraw function and remove export

  hannahker

  committed
  6064e5a

  Copy full SHA for 6064e5a

Commits on Dec 21, 2022

• Adjust API to have both autoshift and shift params

  hannahker

  committed
  085c2b7

  Copy full SHA for 085c2b7

• Update plot schema and baseline

  hannahker

  committed
  49ddf46

  Copy full SHA for 49ddf46

• Adjust logic for default setting

  hannahker

  committed
  a45eca6

  Copy full SHA for a45eca6

• Adjust text for docs

  hannahker

  committed
  56605bc

  Copy full SHA for 56605bc

• Improve documentation and simplify syntax

  hannahker

  committed
  5506ed4

  Copy full SHA for 5506ed4

• set ax._fullDepth only when needed

  archmoj

  committed
  61c2889

  Copy full SHA for 61c2889

• simplify autoshift checks

  archmoj

  committed
  d06bc6d

  Copy full SHA for d06bc6d

• adjust description keys and values

  archmoj

  committed
  bab8020

  Copy full SHA for bab8020

• no shift when zero

  archmoj

  committed
  09b5d0c

  Copy full SHA for 09b5d0c

• do not add autoshift and shift to xaxis for now

  archmoj

  committed
  b89f59a

  Copy full SHA for b89f59a

• adjust asterisks for new attributes shift & autoshift

  archmoj

  committed
  948809b

  Copy full SHA for 948809b