Skip to content

Hover on fills #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 22, 2016
Merged

Hover on fills #673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
43e8d30
hoveron=fills initial commit
alexcjohnson Jun 20, 2016
8aa4397
fix bug in heatmap + non-heatmap hover
alexcjohnson Jun 20, 2016
876bd1d
put fill hover label at the right (or left) middle.
alexcjohnson Jun 20, 2016
2018a74
prev trace changes fill hover the same way as it changes fill itself
alexcjohnson Jun 20, 2016
c7a9dd5
couple of perf and style tweaks to regular point hover
alexcjohnson Jun 20, 2016
5552c77
test hoveron=fills label position and text
alexcjohnson Jun 20, 2016
ffd56c7
fix and test hoveron=fills for scatterternary
alexcjohnson Jun 20, 2016
dddb6e1
lock test graphDiv to position 0,0 and other jasmine reliability tweaks
alexcjohnson Jun 21, 2016
1931102
test hoveron in supplyDefaults
alexcjohnson Jun 21, 2016
47d2df8
Merge branch 'master' into hoveron-fill
alexcjohnson Jun 21, 2016
025b788
more lenient test of hoveron fills label position
alexcjohnson Jun 21, 2016
1a685d4
appease eslint :cow2:
alexcjohnson Jun 21, 2016
f22fac8
give back a little more time in click_test doubleclick
alexcjohnson Jun 21, 2016
ba77f5b
copy hoveron fill testing mocks
alexcjohnson Jun 21, 2016
1d1a0f7
lib.coerce: allow flaglist with no extras
alexcjohnson Jun 21, 2016
aec4c95
make hoveron a flaglist
alexcjohnson Jun 21, 2016
1e86eb2
update scatter(ternary) supplyDefaults test for hoveron flaglist
alexcjohnson Jun 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/traces/heatmap/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@
'use strict';

var Fx = require('../../plots/cartesian/graph_interact');
var constants = require('../../plots/cartesian/constants');
var Lib = require('../../lib');


module.exports = function hoverPoints(pointData, xval, yval, hovermode, contour) {
// never let a heatmap override another type as closest point
if(pointData.distance < Fx.MAXDIST) return;
if(pointData.distance < constants.MAXDIST) return;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard I didn't notice you fixed this issue in #655 too - but when I merged master back in I used your version, which is cleaner.


var cd0 = pointData.cd[0],
trace = cd0.trace,
Expand Down Expand Up @@ -46,8 +47,8 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode, contour)
return;
}
}
else if(Fx.inbox(xval - x[0], xval - x[x.length - 1]) > Fx.MAXDIST ||
Fx.inbox(yval - y[0], yval - y[y.length - 1]) > Fx.MAXDIST) {
else if(Fx.inbox(xval - x[0], xval - x[x.length - 1]) > constants.MAXDIST ||
Fx.inbox(yval - y[0], yval - y[y.length - 1]) > constants.MAXDIST) {
return;
}
else {
Expand Down Expand Up @@ -99,7 +100,7 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode, contour)
return [Lib.extendFlat(pointData, {
index: [ny, nx],
// never let a 2D override 1D type as closest point
distance: Fx.MAXDIST + 10,
distance: constants.MAXDIST + 10,
x0: x0,
x1: x1,
y0: y0,
Expand Down
3 changes: 2 additions & 1 deletion src/traces/scatter/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

var Lib = require('../../lib');
var Fx = require('../../plots/cartesian/graph_interact');
var constants = require('../../plots/cartesian/constants');
var ErrorBars = require('../../components/errorbars');
var getTraceColor = require('./get_trace_color');
var Color = require('../../components/color');
Expand Down Expand Up @@ -59,7 +60,7 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {

Lib.extendFlat(pointData, {
// never let a 2D override 1D type as closest point
distance: Fx.MAXDIST + 10,
distance: constants.MAXDIST + 10,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the + 10 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as heatmap - other types will return a distance that's no bigger than MAXDIST, so as long as we make this distance more than that, any matching scatter points always win. +10 is arbitrary, but I suppose we could make a priority ladder by making this different from heatmap in case of overlaps? Or leave them identical so trace order is the tiebreaker (though I don't actually know whether the first or last match will get it... I guess for visual consistency it should be the last trace, wouldn't it be clever if I wrote it that way???)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity with heatmaps is fine for now. Thanks for the clarification. 👍

x0: x0,
x1: x1,
y0: y0,
Expand Down