Skip to content

Skip mapbox failing tests for now #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Skip mapbox failing tests for now #7083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b44778
skip mapbox comparison for now
archmoj Aug 8, 2024
75ab5f0
blacklist map_angles which is very flaky
archmoj Aug 8, 2024
32e3b64
skip mapbox custom attribution test on CI for now
archmoj Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ argv._.forEach(function(pattern) {
});

var blacklist = [
'map_angles',
'map_stamen-style',
'mapbox_stamen-style',
'mapbox_custom-style',
Expand Down Expand Up @@ -108,6 +109,11 @@ for(var i = 0; i < allMockList.length; i++) {
if(blacklist.indexOf(mockName) !== -1) continue;

var isMapbox = mockName.substr(0, 7) === 'mapbox_';

// We have to skip mapbox since Aug 2024
// See https://github.com/plotly/plotly.js/issues/7075
if(isMapbox) continue;

var isOtherFlaky = [
// list flaky mocks other than mapbox:
'map_density0-legend',
Expand Down Expand Up @@ -160,7 +166,6 @@ for(var i = 0; i < allMockList.length; i++) {

var threshold = shouldBePixelPerfect ? 0 : [
// more flaky
'map_angles',
'mapbox_angles',
'mapbox_layers',
'mapbox_custom-style',
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/mapbox_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,7 @@ describe('mapbox plots', function() {
.then(done, done.fail);
});

it('@gl should be displayed for attributions defined in layers\' sourceattribution', function(done) {
it('@noCI @gl should be displayed for attributions defined in layers\' sourceattribution', function(done) {
var mock = require('../../image/mocks/mapbox_layers.json');
var customMock = Lib.extendDeep(mock);

Expand Down