Skip to content

Adding pointcloud #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 7, 2016
Merged

Adding pointcloud #850

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3dd18ea
Pointcloud - plotly,js bindings (squashed)
monfera Sep 1, 2016
7b6edbc
Pointcloud - image test
monfera Sep 1, 2016
95925a3
PR feedback - rename indexid to indices
monfera Sep 2, 2016
5f4847d
PR feedback - camelcasing
monfera Sep 2, 2016
bfd0af8
PR feedback- split bounds to xbounds / ybounds
monfera Sep 2, 2016
6871cb3
Add support for permutations of direct array support
monfera Sep 2, 2016
16f7fd5
Add support for permutations of direct array support - test cases
monfera Sep 2, 2016
a69af31
Use the npm publish - ed version of gl-pointcloud2d
monfera Sep 7, 2016
5d37b54
removing the typed array based test cases as they aren't JSON
monfera Sep 7, 2016
8a09ccd
Added comment
monfera Sep 7, 2016
8105955
jasmine test case for pointcloud
monfera Sep 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/traces/pointcloud/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ proto.updateFast = function(options) {
if(xy) {

positions = xy;

// dividing xy.length by 2 and truncating to integer if xy.length was not even
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

len = xy.length >>> 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).


if(userBounds) {
Expand Down