Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the bundled version of plotly.js to 1.43.1.
This one required a bit more that simply rerunning code generation due to the changes in
title
parameters. In plotly.js 1.43.0+ alltitle
parameters no longer hold strings but they are objects with multiple sub-properties. Furtherore, all of thetitle*
properties have now been moved under the associatedtitle
compound property.Plotly.js still accepts
title
as a string and it still accepts the legacytitle*
properties, but plotly.py can't rely on this because it looks at the plotly.js_fullLayout
property to compute differences between what has been specified explicitly and what has been computed automatically by plotly.js. So plotly.py needs to provide its own backward compatibility support for these properties. This involved two changes.title
property (e.g.layout.title
), a new validator base class coerces this into the dict{'text': val}
.title*
property is remapped to the correspondingtitle.*
property.So these changes are almost entirely backwards compatible. The only exception (and I don't think there's a reasonable way to get around this) is that the getter for
title
properties (e.g.layout.title
) will no longer return a string, but a compound title obejct (e.g.go.layout.Title()
)