Skip to content

Try to coerce all objects to Numpy arrays. #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 17, 2019
Merged

Try to coerce all objects to Numpy arrays. #1393

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c96ae9
Try to coerce all objects to Numpy arrays.
malmaud Jan 11, 2019
fdef64c
Move conversion logic to copy_to_readonly_numpy_array
malmaud Jan 14, 2019
51f13af
Don't convert numpy scalars to arrays.
malmaud Jan 15, 2019
fe089b8
Update tests.
malmaud Jan 16, 2019
78dce40
Tweaks
malmaud Jan 16, 2019
322f3a7
Check for numpy
malmaud Jan 16, 2019
ef07063
Downgrade xarray version
malmaud Jan 16, 2019
affd115
Add comment.
malmaud Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ deps=
optional: pyshp==1.2.10
optional: pillow==5.2.0
optional: matplotlib==2.2.3
optional: xarray==0.11.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future reference, what kind of problem did this cause?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests reported that 0.10.9 was the highest version of xarray available. I guess xarray added some upper bound to its dependencies in the 0.11 series that rendered it incompatible with the environment of the test - I didn't really investigate too closely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info. I figured it was a transitive dependency issue, just wanted to double check.

optional: xarray==0.10.9

; CORE ENVIRONMENTS
[testenv:py27-core]
Expand Down