Code

Revamp tls.get_subplots#170

Code

Merged

etpinard merged 104 commits intomasterplotly/plotly.py:masterfrom

revamp-get_subplotsplotly/plotly.py:revamp-get_subplotsCopy head branch name to clipboard

Jan 13, 2015

Commits

Commits on Dec 22, 2014

• add specs to revamped get_subplots()

  etpinard

  committed
  9b2f4c0

  Copy full SHA for 9b2f4c0

Commits on Dec 29, 2014

• sync latest graph ref master

  etpinard

  committed
  637c5de

  Copy full SHA for 637c5de

Commits on Dec 30, 2014

• update get_subplots() docstring

  etpinard

  committed
  55637e0

  Copy full SHA for 55637e0

• remove old get_subplots() code

  etpinard

  committed
  1b1d23a

  Copy full SHA for 1b1d23a

• add Exception if rows or/and columns are not integers

  etpinard

  committed
  76c6d4e

  Copy full SHA for 76c6d4e

• make h/v spacing depend on the number of rows/columns:

  Show description for 9f1c240
  etpinard

  committed
  9f1c240

  Copy full SHA for 9f1c240

• initialize specs list of lists:

  Show description for 5406fb3
  etpinard

  committed
  5406fb3

  Copy full SHA for 5406fb3

• compute some common distances

  etpinard

  committed
  26f704e

  Copy full SHA for 26f704e

• loop through specs:

  Show description for d9341c8
  etpinard

  committed
  d9341c8

  Copy full SHA for d9341c8

• add _get_shared()

  etpinard

  committed
  8705058

  Copy full SHA for 8705058

• add _add_domain() and _add_domain_is3D()

  etpinard

  committed
  842ff88

  Copy full SHA for 842ff88

• add _fill_grid()

  etpinard

  committed
  c55a92f

  Copy full SHA for c55a92f

• initialize looping variables

  etpinard

  committed
  34ee502

  Copy full SHA for 34ee502

• (oops) get_shared -> _get_shared

  etpinard

  committed
  97145a5

  Copy full SHA for 97145a5

• add print_grid

  etpinard

  committed
  5dfcfad

  Copy full SHA for 5dfcfad

• modify computed domain in existing tests (because of rounding errors)

  etpinard

  committed
  f72a249

  Copy full SHA for f72a249

• modify arguments in existing tests:

  Show description for 857a7d7
  etpinard

  committed
  857a7d7

  Copy full SHA for 857a7d7

• test galore git diff --cached !

  etpinard

  committed
  e64794b

  Copy full SHA for e64794b

Commits on Dec 31, 2014

• improve algorithm (part 1):

  Show description for ab661f4
  etpinard

  committed
  ab661f4

  Copy full SHA for ab661f4

• improve algorithm (part 2):

  Show description for eced9a3
  etpinard

  committed
  eced9a3

  Copy full SHA for eced9a3

• improve algorithm (part 3):

  Show description for 55a9b3f
  etpinard

  committed
  55a9b3f

  Copy full SHA for 55a9b3f

• improve algorithm (part 4):

  Show description for 3eba0d7
  etpinard

  committed
  3eba0d7

  Copy full SHA for 3eba0d7

• improve algorthm (part 5):

  Show description for 79c9868
  etpinard

  committed
  79c9868

  Copy full SHA for 79c9868

• remove _get_shared()

  etpinard

  committed
  ca08227

  Copy full SHA for ca08227

• add _get_label()

  etpinard

  committed
  4efbb4f

  Copy full SHA for 4efbb4f

• add _get_anchors

  etpinard

  committed
  69214c6

  Copy full SHA for 69214c6

• update _add_domain and _add_domain_is3D

  etpinard

  committed
  0497009

  Copy full SHA for 0497009

• code aesthetics

  etpinard

  committed
  a83ad48

  Copy full SHA for a83ad48

• modify expected values in tests due to rounding errors

  etpinard

  committed
  2d781f6

  Copy full SHA for 2d781f6

• add 2nd rowspan test (that discovered the bug)

  etpinard

  committed
  b8e9f53

  Copy full SHA for b8e9f53

• more test updating due to rounding errors

  etpinard

  committed
  46ed9d7

  Copy full SHA for 46ed9d7

• update shared axis tests

  etpinard

  committed
  540b734

  Copy full SHA for 540b734

• add 1 shared_xaxes=True, shared_yaxes=True test

  etpinard

  committed
  7b0e8fb

  Copy full SHA for 7b0e8fb

Commits on Jan 2, 2015

• sub isEmpty -> is_empyt , is3D -> is_3d

  etpinard

  committed
  f6a64d1

  Copy full SHA for f6a64d1

Commits on Jan 4, 2015

• add info about 'insets' in docstring

  etpinard

  committed
  bed60db

  Copy full SHA for bed60db

• add try/except block for kwargs['insets']

  etpinard

  committed
  50eeb8f

  Copy full SHA for 50eeb8f

• aesthestic in SPEC_defaults

  etpinard

  committed
  1a2192e

  Copy full SHA for 1a2192e

• add functions checking and filling keys (for 'specs' & 'insets')

  etpinard

  committed
  443217e

  Copy full SHA for 443217e

• send specs to _check_keys_and_fill()

  etpinard

  committed
  a72f043

  Copy full SHA for a72f043

• check and fill 'insets'

  etpinard

  committed
  8e3e83d

  Copy full SHA for 8e3e83d

• raise Exception if non-valid kwarg is sent to get_subplots

  etpinard

  committed
  d30e7b9

  Copy full SHA for d30e7b9

• loop through insets!

  etpinard

  committed
  f9235b3

  Copy full SHA for f9235b3

• add inset str reprensation

  etpinard

  committed
  dfa47f7

  Copy full SHA for dfa47f7

• add wrong key & wrong type tests

  etpinard

  committed
  3ef8116

  Copy full SHA for 3ef8116

• add 2 insets tests

  etpinard

  committed
  ec25258

  Copy full SHA for ec25258

• update 'specs' docstring

  etpinard

  committed
  25c8d85

  Copy full SHA for 25c8d85

• raise Exception if specs dims not equal to 'rows' and 'columns'

  etpinard

  committed
  330eeac

  Copy full SHA for 330eeac

• rm 'is_empty' from SPEC_defaults

  etpinard

  committed
  12cdffd

  Copy full SHA for 12cdffd

• add cond for spec == None case in check_and_fill

  etpinard

  committed
  e52ff4f

  Copy full SHA for e52ff4f

• pep8 tuple

  etpinard

  committed
  bad84cd

  Copy full SHA for bad84cd

• move spec is None cond at top of spec loop

  etpinard

  committed
  0c83b9d

  Copy full SHA for 0c83b9d

Commits on Jan 5, 2015

• re-align specs loop

  etpinard

  committed
  45229d2

  Copy full SHA for 45229d2

• move right by one column:

  Show description for fa286a0
  etpinard

  committed
  fa286a0

  Copy full SHA for fa286a0

• add under/over-specified specs tests

  etpinard

  committed
  f0c3997

  Copy full SHA for f0c3997

• update tests:

  Show description for feea0cc
  etpinard

  committed
  feea0cc

  Copy full SHA for feea0cc

• add a colspan>1 + rowspan>1 in the same cell test

  etpinard

  committed
  98b955f

  Copy full SHA for 98b955f

• [need some feedback] add start_cell docstring

  etpinard

  committed
  e5d753f

  Copy full SHA for e5d753f

Commits on Jan 6, 2015

• add back the old get_subplots :

  Show description for 0d74fb3
  etpinard

  committed
  0d74fb3

  Copy full SHA for 0d74fb3

• mv get_subplots argument checks tests to the top of file

  etpinard

  committed
  6df366e

  Copy full SHA for 6df366e

• move make_subplots tests to test_make_subplots.py

  etpinard

  committed
  5bcbaaa

  Copy full SHA for 5bcbaaa

• pep8 get_subplots docstring

  etpinard

  committed
  2edb810

  Copy full SHA for 2edb810

Commits on Jan 7, 2015

• improve make_subplots docstring

  etpinard

  committed
  421dd5f

  Copy full SHA for 421dd5f

• replace 'columns' with 'cols'

  etpinard

  committed
  af67e90

  Copy full SHA for af67e90

• rm '>>>' in docstring

  etpinard

  committed
  7bb6ba2

  Copy full SHA for 7bb6ba2

• force 'specs' to be list of lists

  etpinard

  committed
  67672dd

  Copy full SHA for 67672dd

• force items in 'specs' to be either dicts or None

  etpinard

  committed
  a311719

  Copy full SHA for a311719

• define START_CELL and build grid using it

  etpinard

  committed
  dd16fa2

  Copy full SHA for dd16fa2

• sub 'grid_str' -> 'grid_ref':

  Show description for 254cf13
  etpinard

  committed
  254cf13

  Copy full SHA for 254cf13

• fill in a layout obj, not a figure obj directly

  etpinard

  committed
  46b6c73

  Copy full SHA for 46b6c73

• remove i, j indices

  etpinard

  committed
  4a6b718

  Copy full SHA for 4a6b718

• improve and generalize algorithm:

  Show description for 1cb0026
  etpinard

  committed
  1cb0026

  Copy full SHA for 1cb0026

• rm grid_str code (taken care outside specs loop now)

  etpinard

  committed
  964daff

  Copy full SHA for 964daff

• update (r, c) convention:

  Show description for 7463f60
  etpinard

  committed
  7463f60

  Copy full SHA for 7463f60

• update _add_domain (accepts layout not fig)

  etpinard

  committed
  f0eea15

  Copy full SHA for f0eea15

• update insets loop:

  Show description for 95cded8
  etpinard

  committed
  95cded8

  Copy full SHA for 95cded8

• improve 'grid_str' code

  etpinard

  committed
  7b0e5d1

  Copy full SHA for 7b0e5d1

• pep8 and add TODO

  etpinard

  committed
  3f7572a

  Copy full SHA for 3f7572a

• test galore !!!

  Show description for e9c2e01
  etpinard

  committed
  e9c2e01

  Copy full SHA for e9c2e01

• add exception for out of range 'insets.cell'

  etpinard

  committed
  bfa69ce

  Copy full SHA for bfa69ce

• add tests for prev commit

  etpinard

  committed
  0f75a2d

  Copy full SHA for 0f75a2d

• sync for graph ref (trace 'scene')

  etpinard

  committed
  9c34d84

  Copy full SHA for 9c34d84

Commits on Jan 9, 2015

• make print_grid=True the default for make_subplots

  etpinard

  committed
  d39a0be

  Copy full SHA for d39a0be

• sub '!' -> ':' in print grid msg

  etpinard

  committed
  87d645a

  Copy full SHA for 87d645a

• update shared_{x,y}axes docstring

  etpinard

  committed
  08892a9

  Copy full SHA for 08892a9

• capitalize ROW_DIR

  etpinard

  committed
  e4d4936

  Copy full SHA for e4d4936

• update get_anchors logic:

  Show description for 2de9ad7
  etpinard

  committed
  2de9ad7

  Copy full SHA for 2de9ad7

• add shared axes tests

  etpinard

  committed
  bd16672

  Copy full SHA for bd16672

• paste grid_ref and grid_str to fig in make_subplots

  etpinard

  committed
  6b2465b

  Copy full SHA for 6b2465b

• add print_grid method to Figure

  etpinard

  committed
  0437513

  Copy full SHA for 0437513

• add append_trace method to Figure

  etpinard

  committed
  9a2767b

  Copy full SHA for 9a2767b

• make _grid_ref and _grid_str attributes

  etpinard

  committed
  f13a408

  Copy full SHA for f13a408

• fix typo in exception msg

  etpinard

  committed
  857013c

  Copy full SHA for 857013c

• better test name

  etpinard

  committed
  7e2d3e0

  Copy full SHA for 7e2d3e0

• add exception for row/col =< 0

  etpinard

  committed
  ff0a112

  Copy full SHA for ff0a112

• add tests for append_trace

  etpinard

  committed
  8dc3f80

  Copy full SHA for 8dc3f80

• force set axis.position when anchor == 'free'

  etpinard

  committed
  87501d8

  Copy full SHA for 87501d8

• update tests

  etpinard

  committed
  cebfae2

  Copy full SHA for cebfae2

• update make_subplot docstring

  etpinard

  committed
  68aee36

  Copy full SHA for 68aee36

• add docstring to append_trace and print_grid

  etpinard

  committed
  4ee9b59

  Copy full SHA for 4ee9b59

Commits on Jan 10, 2015

• add Exception if rows / cols <= 0

  etpinard

  committed
  d2d7a92

  Copy full SHA for d2d7a92

• add tests about last commit

  etpinard

  committed
  1f1960d

  Copy full SHA for 1f1960d

• add example in Figure.append_trace docstring on ref in make_subplots

  etpinard

  committed
  e0301ad

  Copy full SHA for e0301ad

• v 1.5.0

  etpinard

  committed
  3ac711f

  Copy full SHA for 3ac711f

• Merge branch 'master' into revamp-get_subplots

  Show description for 5536194
  etpinard

  committed
  5536194

  Copy full SHA for 5536194