Skip to content

bump Orca to 1.3.1 #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/create_conda_optional_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ if [ ! -d $HOME/miniconda/envs/circle_optional ]; then
requests nbformat six retrying psutil pandas decorator pytest mock nose poppler xarray scikit-image ipython jupyter ipykernel ipywidgets

# Install orca into environment
$HOME/miniconda/bin/conda install --yes -n circle_optional -c plotly plotly-orca=1.2.1
$HOME/miniconda/bin/conda install --yes -n circle_optional -c plotly plotly-orca==1.3.1
fi
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ installation of the plotly [orca](https://github.com/plotly/orca) command line u
These dependencies can both be installed using conda:

```
conda install -c plotly plotly-orca==1.2.1 psutil
conda install -c plotly plotly-orca==1.3.1 psutil
```

Or, `psutil` can be installed using pip...
Expand Down
5 changes: 4 additions & 1 deletion packages/python/plotly/plotly/io/_orca.py
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,10 @@ def ensure_server():
# specified port.
DEVNULL = open(os.devnull, "wb")
with orca_env():
orca_state["proc"] = subprocess.Popen(cmd_list, stdout=DEVNULL)
stderr = DEVNULL if "CI" in os.environ else None # fix for CI
orca_state["proc"] = subprocess.Popen(
cmd_list, stdout=DEVNULL, stderr=stderr
)

# Update orca.status so the user has an accurate view
# of the state of the orca server
Expand Down
2,723 changes: 1,241 additions & 1,482 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/failed/fig1.eps

Large diffs are not rendered by default.

2,405 changes: 1,199 additions & 1,206 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/fig1.eps

Large diffs are not rendered by default.

4,696 changes: 3,874 additions & 822 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/latexfig.eps

Large diffs are not rendered by default.

9,663 changes: 7,954 additions & 1,709 deletions packages/python/plotly/plotly/tests/test_orca/images/linux/topofig.eps

Large diffs are not rendered by default.