Skip to content

complete the API of plotly.colors and plotly.express.colors #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2020

Conversation

emmanuelle
Copy link
Contributor

API exposed:

image

@jonmmease
Copy link
Contributor

Thanks @emmanuelle! In terms of the imports, I think we also need to add these to the __all__ lists:

  • plotlyjs
  • DEFAULT_PLOTLY_COLORS
  • PLOTLY_SCALES

I don't feel strongly that these need to be in the documentation, just that imports keep working.

@emmanuelle
Copy link
Contributor Author

@jonmmease done! Lists do not appear in the sphinx documentation and I did not do the copy thing for the plotlyjs module so this does not change the API doc. But of course now the objects can be imported both from plotly.colors and px.colors.

@nicolaskruchten nicolaskruchten added this to the 4.8.1 milestone May 28, 2020
@nicolaskruchten
Copy link
Contributor

💃 !

It would be nice to clean up the docstrings in these functions a bit, maybe when we do #2484 ... I can't tell if any of these functions actually already do this!

@emmanuelle emmanuelle merged commit 8dd6ed5 into master May 28, 2020
@nicolaskruchten nicolaskruchten deleted the fix-colors branch June 19, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants